Added support for secure HTTPS xPack requests #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuisGi93
reviewed
Mar 15, 2019
|
|
||
| until curl -XGET $el_url; do | ||
| until curl ${auth} -XGET $el_url; do |
There was a problem hiding this comment.
Better to follow the same style as the rest of the document for specifying the auth credentials:
curl -XGET $el_url ${auth}
|
Hi team, |
LuisGi93
suggested changes
Mar 20, 2019
LuisGi93
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello team,
This PR adds the ability to perform requests to the Elastic API in the case of xPack enabled.
Related issue: #50
Cheers