Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docker-compose.yml #1192

Closed
wants to merge 2 commits into from
Closed

Update docker-compose.yml #1192

wants to merge 2 commits into from

Conversation

wuast94
Copy link

@wuast94 wuast94 commented Jan 19, 2024

  1. Link is lagacy, replaced with bridge network: https://docs.docker.com/network/links/
  2. fixed service names, dots are somehow allowed but making problems, didnt find docs for this\
  3. fixed versions tags

@wuast94 wuast94 mentioned this pull request Jan 22, 2024
Closed
@rauldpm rauldpm linked an issue Jan 22, 2024 that may be closed by this pull request
docker-compose broken #1191
Closed
rauldpm
rauldpm previously requested changes Jan 22, 2024
View reviewed changes
Copy link
Member

@rauldpm rauldpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restore the version references to 4.9.0 as the master branch refers to that version, if you want to see 4.7.2 related files, please use the tag v4.7.2

@wuast94
Copy link
Author

wuast94 commented Jan 22, 2024

hope that was right @rauldpm ? im new to github 😅

@wuast94 wuast94 requested a review from rauldpm January 22, 2024 17:25
@rauldpm
Copy link
Member

rauldpm commented Jan 22, 2024 •
edited

hope that was right @rauldpm ? im new to github 😅

Yes! Now the @wazuh/cicd team must review it and decide if this is going to be merged or not or if this needs more changes, they have been informed about this so please be patient! Thanks!

@rauldpm rauldpm dismissed their stale review January 22, 2024 20:02

Requested changes have been applied

@wuast94 wuast94 closed this by deleting the head repository Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauldpm rauldpm Awaiting requested review from rauldpm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker-compose broken
2 participants
@wuast94 @rauldpm