Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation to include user .aws/config file as default config #6005

Merged

Conversation

EduLeon12
Copy link
Contributor

Description

AWS Module now supports using the ~/.aws/config file as the default configuration for the client.

Documentation has been updated to include how to configure user file to be sued as default configuration.

Checks

  • Compiles without warnings.
  • Uses present tense, active voice, and semi-formal registry.
  • Uses short, simple sentences.
  • Uses bold for user interface elements, italics for key terms or emphasis, and code font for Bash commands, file names, REST paths, and code.
  • Uses three spaces indentation.
  • Adds or updates meta descriptions accordingly.
  • Updates the redirects.js script if necessary (check this guide).

@EduLeon12 EduLeon12 added aws aws wodle documentation aws_integration labels Mar 30, 2023
@EduLeon12 EduLeon12 self-assigned this Mar 30, 2023
@EduLeon12 EduLeon12 linked an issue Mar 30, 2023 that may be closed by this pull request
5 tasks
Copy link
Contributor

@s-ocando s-ocando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @EduLeon12, please review the suggestions below.

source/amazon/services/prerequisites/considerations.rst Outdated Show resolved Hide resolved
source/amazon/services/prerequisites/considerations.rst Outdated Show resolved Hide resolved
source/amazon/services/prerequisites/considerations.rst Outdated Show resolved Hide resolved
@EduLeon12
Copy link
Contributor Author

Hi @s-ocando ,
Thanks for the review and the suggested changes, they all had been committed.

@EduLeon12 EduLeon12 requested a review from s-ocando March 31, 2023 11:19
@Selutario
Copy link
Member

@s-ocando the development was already merged so this is ready too!

@EduLeon12 EduLeon12 force-pushed the 14978-update-aws-to-take-user-config-file-as-default-config branch from 0cd4d24 to 5a8bcb7 Compare August 24, 2023 11:54
@s-ocando s-ocando merged commit 1e35b82 into 4.6.0 Aug 24, 2023
@s-ocando s-ocando deleted the 14978-update-aws-to-take-user-config-file-as-default-config branch August 24, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review and modify default_config method in AWS module
4 participants