Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add discard_regex parameter to Services #6207

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Add discard_regex parameter to Services #6207

merged 3 commits into from
Jul 18, 2023

Conversation

fdalmaup
Copy link
Member

@fdalmaup fdalmaup commented Jul 4, 2023 •
edited
Loading

Description

This PR is part of wazuh/wazuh#17388. It adds the discard_regex parameter to the Services section of the AWS module reference.

Checks

  • Compiles without warnings.
  • Uses present tense, active voice, and semi-formal registry.
  • Uses short, simple sentences.
  • Uses bold for user interface elements, italics for key terms or emphasis, and code font for Bash commands, file names, REST paths, and code.
  • Uses three spaces indentation.
  • Adds or updates meta descriptions accordingly.
  • Updates the redirects.js script if necessary (check this guide).

@fdalmaup fdalmaup self-assigned this Jul 4, 2023
@fdalmaup fdalmaup mentioned this pull request Jul 4, 2023
Closed
7 tasks
@fdalmaup fdalmaup linked an issue Jul 5, 2023 that may be closed by this pull request
Update AWS Services to make use of the discard_regex functionality wazuh/wazuh#17388
Closed
7 tasks
@fdalmaup fdalmaup force-pushed the 17388-update-aws-services-section branch from 2b44ab0 to fb43956 Compare July 12, 2023 20:21
@fdalmaup fdalmaup changed the base branch from master to 4.5.1 July 12, 2023 20:21
EduLeon12
EduLeon12 approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@EduLeon12 EduLeon12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Selutario
Selutario approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@Selutario Selutario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Selutario Selutario requested a review from javimed July 17, 2023 12:53
@javimed javimed merged commit 3538c44 into 4.5.1 Jul 18, 2023
@javimed javimed deleted the 17388-update-aws-services-section branch July 18, 2023 13:10
@s-ocando s-ocando mentioned this pull request Aug 24, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Selutario Selutario Selutario approved these changes

@javimed javimed javimed approved these changes

@EduLeon12 EduLeon12 EduLeon12 approved these changes

Assignees

@fdalmaup fdalmaup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update AWS Services to make use of the discard_regex functionality
4 participants
@fdalmaup @Selutario @javimed @EduLeon12