Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in GCP configuration examples #6509

Merged
merged 5 commits into from
Sep 15, 2023

Conversation

javiersanchz
Copy link
Member

@javiersanchz javiersanchz commented Sep 14, 2023

Description

A correction was made to the GCP configuration example. Blank spaces were removed, and the <project_id> and <subscription_name> fields within the section were deleted as they are specific to pubsub, as mentioned in issue number #6482 . Additionally, the remaining fields were added.

Checks

Docs building

  • Compiles without warnings.

Code formatting and web optimization

  • Uses three spaces indentation.
  • Adds or updates meta descriptions accordingly.
  • Updates the redirects.js script if necessary (check this guide).

Writing style

  • Uses present tense, active voice, and semi-formal registry.
  • Uses short, simple sentences.
  • Uses bold for user interface elements, italics for key terms or emphasis, and code font for Bash commands, file names, REST paths, and code.

@javiersanchz javiersanchz self-assigned this Sep 14, 2023
@javiersanchz javiersanchz linked an issue Sep 14, 2023 that may be closed by this pull request
@fdalmaup fdalmaup self-requested a review September 14, 2023 12:23
Copy link
Member

@fdalmaup fdalmaup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Selutario Selutario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also a wrong example in the Configuration example section of the Local configuration (ossec.conf) > gcp-bucket page.

Please, update it too.

@javimed javimed added level/task Task issue type/bug Bug issue labels Sep 15, 2023
@javimed javimed self-requested a review September 15, 2023 15:16
@javimed javimed merged commit f0913fe into 4.6.0 Sep 15, 2023
@javimed javimed deleted the feature/6482-errors-gcp-configuration-examples branch September 15, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/task Task issue type/bug Bug issue
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Errors in GCP configuration examples
4 participants