Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds missing RBAC References. #6693

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Adds missing RBAC References. #6693

merged 1 commit into from
Nov 10, 2023

Conversation

RamosFe
Copy link
Member

@RamosFe RamosFe commented Oct 27, 2023

Issue: #6422

Description

Adds PUT /decoders/files/{filename} and PUT /rules/files/{filename} missing RBAC policies.

@RamosFe RamosFe self-assigned this Oct 27, 2023
@RamosFe RamosFe linked an issue Oct 27, 2023 that may be closed by this pull request
Fix rbac reference for decoders and rules #6422
Closed
@GGP1 GGP1 self-requested a review October 30, 2023 15:52
GGP1
GGP1 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@GGP1 GGP1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Selutario
Selutario suggested changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@Selutario Selutario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but since the release type is patch, this should not be targeting master branch.
image

Change the base branch to 4.7.1 or even 4.6 (so it takes effect almost instantly)

@RamosFe
Adds missing RBAC References.
e4628f2 
Adds PUT /decoders/files/{filename} and PUT /rules/files/{filename} missing RBAC policies.
@RamosFe RamosFe force-pushed the add/6422-missing-rbac-references branch from b987695 to e4628f2 Compare November 10, 2023 12:19
@RamosFe RamosFe changed the base branch from master to 4.7.1 November 10, 2023 12:20
@javimed javimed added level/task Task issue type/bug Bug issue labels Nov 10, 2023
@javimed javimed merged commit 23b9549 into 4.7.1 Nov 10, 2023
3 checks passed
@javimed javimed deleted the add/6422-missing-rbac-references branch November 10, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Selutario Selutario Selutario approved these changes

@javimed javimed javimed approved these changes

@GGP1 GGP1 GGP1 approved these changes

Assignees

@RamosFe RamosFe

Labels
level/task Task issue type/bug Bug issue
Projects
No open projects
Release 4.7.1
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix rbac reference for decoders and rules
4 participants
@RamosFe @Selutario @javimed @GGP1