Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GCP documentation #6964

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Update GCP documentation #6964

merged 3 commits into from
Jan 19, 2024

Conversation

GGP1
Copy link
Member

@GGP1 GGP1 commented Jan 16, 2024

Description

Updated the Google cloud services documentation to be more specific about the creation of resources and the options available when doing so.

Checks

Docs building

  • Compiles without warnings.

Code formatting and web optimization

  • Uses three spaces indentation.
  • Adds or updates meta descriptions accordingly.
  • Updates the redirects.js script if necessary (check this guide).

Writing style

  • Uses present tense, active voice, and semi-formal registry.
  • Uses short, simple sentences.
  • Uses bold for user interface elements, italics for key terms or emphasis, and code font for Bash commands, file names, REST paths, and code.

@GGP1 GGP1 self-assigned this Jan 16, 2024
@GGP1 GGP1 linked an issue Jan 16, 2024 that may be closed by this pull request
Copy link
Contributor

@EduLeon12 EduLeon12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good improvement to list the steps.

LGTM !!

@javimed javimed added level/task Task issue type/enhancement Enhancement issue labels Jan 17, 2024
source/cloud-security/gcp/prerequisites/credentials.rst Outdated Show resolved Hide resolved
source/cloud-security/gcp/prerequisites/pubsub.rst Outdated Show resolved Hide resolved
Every publishing application sends messages to topics. Wazuh will retrieve the logs from this topic. To create it, follow these steps:

#. Go to the **Pub/Sub** service.
#. Click on **CREATE TOPIC**.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image doesn't show "Create topic" as a clickable option. Do we mean to click on the left side panel option "Topics"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Create topic" button is on the previous window, I didn't add an image because I thought it wasn't necessary for that single step. Should we add it?

topics

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just making sure we were using the right reference name.

source/cloud-security/gcp/prerequisites/pubsub.rst Outdated Show resolved Hide resolved
source/cloud-security/gcp/prerequisites/pubsub.rst Outdated Show resolved Hide resolved
@GGP1 GGP1 requested a review from javimed January 18, 2024 12:44
Every publishing application sends messages to topics. Wazuh will retrieve the logs from this topic. To create it, follow these steps:

#. Go to the **Pub/Sub** service.
#. Click on **CREATE TOPIC**.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just making sure we were using the right reference name.

@javimed javimed merged commit a8ea404 into 4.8.0 Jan 19, 2024
@javimed javimed deleted the fix/21441-update-gcp-docs branch January 19, 2024 12:49
@rauldpm rauldpm mentioned this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/task Task issue type/enhancement Enhancement issue
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update GCP integration documentation
4 participants