Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Azure diagnostic step #6987

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

GGP1
Copy link
Member

@GGP1 GGP1 commented Jan 24, 2024

Description

Updates the Azure diagnostic section.

Checks

Docs building

  • Compiles without warnings.

Code formatting and web optimization

  • Uses three spaces indentation.
  • Adds or updates meta descriptions accordingly.
  • Updates the redirects.js script if necessary (check this guide).

Writing style

  • Uses present tense, active voice, and semi-formal registry.
  • Uses short, simple sentences.
  • Uses bold for user interface elements, italics for key terms or emphasis, and code font for Bash commands, file names, REST paths, and code.

@GGP1 GGP1 self-assigned this Jan 24, 2024
@GGP1 GGP1 linked an issue Jan 24, 2024 that may be closed by this pull request
Copy link
Contributor

@EduLeon12 EduLeon12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Selutario Selutario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@javimed javimed added level/task Task issue type/bug Bug issue labels Jan 25, 2024
Copy link
Member

@javimed javimed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is updating the /cloud-security/azure/activity-services/services/storage section. What about the /cloud-security/azure/activity-services/services/log-analytics? Is updating the Diagnostic settings displayed there out of scope? Is there an issue to link to?

imagen

@GGP1
Copy link
Member Author

GGP1 commented Jan 25, 2024

This PR is updating the /cloud-security/azure/activity-services/services/storage section. What about the /cloud-security/azure/activity-services/services/log-analytics? Is updating the Diagnostic settings displayed there out of scope? Is there an issue to link to?

imagen

@javimed This PR's issue is aimed at updating the Azure Storage service documentation. The log analytics is a separate service that hasn't been tested and that has different configurations and additional steps.

I will open a new issue for that, perhaps it's convenient to keep this one blocked until both are ready.

Edit: Here's the issue wazuh/wazuh#21630.

Copy link
Member

@rauldpm rauldpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation compiled without errors 🟢
╰─➤  make html
sphinx-build -b html -d build/doctrees   source build/html
Running Sphinx v7.0.1
loading translations [en-US]... not available for built-in messages
loading pickled environment... done
building [mo]: targets for 0 po files that are out of date
writing output... 
building [html]: targets for 689 source files that are out of date
updating environment: 1 added, 8 changed, 1 removed
reading sources... [100%] user-manual/reference/daemons/wazuh-modulesd                                                                                                                                            
Copying static files for wazuh-doc-images...[100%] img/loading.gif                                                                                                                                                
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
preparing documents... done
writing output... [100%] user-manual/wazuh-indexer/wazuh-indexer-tuning                                                                                                                                           
generating indices... done
writing additional pages... not_found moved-content search done
copying images... [100%] images/manual/wazuh-indexer/indexer-cluster-with-shard-replicas-diagram.png                                                                                                              
copying static files... done
copying extra files... done
dumping search index in English (code: en)... done
dumping object inventory... done
build succeeded.

The HTML pages are in build/html.

Build finished. The HTML pages are in build/html.

Image check 🟡
  • Wrong reference in the image sequence, the next image referrences to frameworkteststorage but the previous references wazuh.com

image

@GGP1 could we get a screenshot with the original wazuh.com?

@davidjiglesias davidjiglesias merged commit 62bb631 into 4.8.0 Feb 1, 2024
@davidjiglesias davidjiglesias deleted the fix/21548-update-diagnostic-step branch February 1, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/task Task issue type/bug Bug issue
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

No Audit Logs for Azure Storage Integration
6 participants