Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added keystore config steps to Vulnerability detection and to Upgradi… #7235

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

aritosteles
Copy link
Contributor

@aritosteles aritosteles commented Apr 25, 2024

Added keystore config steps to Vulnerability detection and to Upgrading central components

Description

Added keystore configuration steps to

  • configuring-scans.rst
  • upgrading-central-components.rst

Checks

Docs building

  • Compiles without warnings.

Code formatting and web optimization

  • Uses three spaces indentation.
  • Adds or updates meta descriptions accordingly.
  • Updates the redirects.js script if necessary (check this guide).

Writing style

  • Uses present tense, active voice, and semi-formal registry.
  • Uses short, simple sentences.
  • Uses bold for user interface elements, italics for key terms or emphasis, and code font for Bash commands, file names, REST paths, and code.

Configuring vulnerability detection:
image

Upgrading central components:
image

@aritosteles aritosteles self-assigned this Apr 25, 2024
@aritosteles aritosteles linked an issue Apr 25, 2024 that may be closed by this pull request
@aritosteles aritosteles linked an issue Apr 25, 2024 that may be closed by this pull request
ncvicchi
ncvicchi previously approved these changes Apr 26, 2024
Copy link
Member

@ncvicchi ncvicchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tdrauncieal
tdrauncieal previously approved these changes Apr 26, 2024
Copy link
Contributor

@tdrauncieal tdrauncieal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@javimed javimed added level/task Task issue type/bug Bug issue labels Apr 26, 2024
Copy link
Member

@javimed javimed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we ok with the steps order? Just mentioning. In the installation guide we have the step before the ossec.conf edition step.

https://github.com/wazuh/wazuh-documentation/blob/v4.8.0-beta6/source/installation-guide/wazuh-server/step-by-step.rst?plain=1#L78-L88

…uring-scans.rst

Co-authored-by: Javier Medeot <javier.medeot@wazuh.com>
@aritosteles aritosteles dismissed stale reviews from tdrauncieal and ncvicchi via b27c64f April 26, 2024 20:09
aritosteles and others added 2 commits April 26, 2024 17:09
…uring-scans.rst

Co-authored-by: Javier Medeot <javier.medeot@wazuh.com>
…uring-scans.rst

Co-authored-by: Javier Medeot <javier.medeot@wazuh.com>
@javimed javimed merged commit 43526c1 into 4.8.0 Apr 26, 2024
3 checks passed
@javimed javimed deleted the enhancement/7230-add-keystore-config-steps branch April 26, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/task Task issue type/bug Bug issue
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Missing keystore step in the upgrade guide
4 participants