Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note for apt installations #7273

Merged
merged 8 commits into from
May 6, 2024

Conversation

Tostti
Copy link
Member

@Tostti Tostti commented Apr 30, 2024

Description

This PR adds a note to the upgrade central components section, for apt installations noting that if the opensearch_dashboards.yml was modified, the system will ask to either keep the modified version or replace it with the updated one, meaning that the user will have to manually add the changes later.

image

Checks

Docs building

  • Compiles without warnings.

Code formatting and web optimization

  • Uses three spaces indentation.
  • Adds or updates meta descriptions accordingly.
  • Updates the redirects.js script if necessary (check this guide).

Writing style

  • Uses present tense, active voice, and semi-formal registry.
  • Uses short, simple sentences.
  • Uses bold for user interface elements, italics for key terms or emphasis, and code font for Bash commands, file names, REST paths, and code.

@Tostti Tostti self-assigned this Apr 30, 2024
@Tostti Tostti marked this pull request as ready for review April 30, 2024 16:04
Desvelao
Desvelao previously approved these changes May 2, 2024
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@javimed javimed added level/task Task issue type/enhancement Enhancement issue labels May 2, 2024
@asteriscos asteriscos self-assigned this May 3, 2024
javimed
javimed previously approved these changes May 3, 2024
@javimed
Copy link
Member

javimed commented May 3, 2024

Added a commit with a new suggestion which I can easily revert. And what about the yum upgrade? Should we remove the file before upgrading to force updating the file?

imagen

@Tostti
Copy link
Member Author

Tostti commented May 3, 2024

Added a commit with a new suggestion which I can easily revert.

LGTM

And what about the yum upgrade? Should we remove the file before upgrading to force updating the file?

I think that it should. In that case we'll be sure that the file is completely replaced

javimed
javimed previously approved these changes May 3, 2024
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

image

@javimed
Copy link
Member

javimed commented May 6, 2024

@Tostti and @Desvelao have agreed to merge these changes.

@javimed javimed merged commit 233ac37 into 4.8.0 May 6, 2024
3 checks passed
@javimed javimed deleted the 7229-add-note-modified-configuration-file-apt branch May 6, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/task Task issue type/enhancement Enhancement issue
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Missing a note warning of the configuration change when updating the dashboard
4 participants