Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update internal options for VD. #7339

Merged
merged 5 commits into from
May 29, 2024
Merged

Update internal options for VD. #7339

merged 5 commits into from
May 29, 2024

Conversation

GabrielEValenzuela
Copy link
Member

Objective

This PR aims to enhance the documentation by including detailed descriptions and usage guidelines for the remediation_lru_size and disable_manager_scan configuration options. This update will assist users and developers in understanding and effectively utilizing these configurations to optimize the performance and behavior of our tools.

Changes Implemented

  • Updated Documentation:
    • Added a section on remediation_lru_size detailing its purpose, default values, and how to adjust it.
    • Introduced information on disable_manager_scan, explaining its functionality.

Implementation Details

  • The documentation has been updated in the respective sections of our configuration management guide.

Testing

  • The documentation changes have been reviewed for clarity, accuracy, and completeness by the documentation team.
  • Technical accuracy has been validated by the development team to ensure that the descriptions match the implemented functionalities.

@GabrielEValenzuela GabrielEValenzuela self-assigned this May 27, 2024
This was linked to issues May 27, 2024
Missing variables in the internal configuration documentation for the Vulnerability Detection module. #7336
Closed
Add documentation on how to disable/enable vulnerability detection in the Manager #7337
Closed
@sebasfalcone sebasfalcone removed a link to an issue May 28, 2024
Add documentation on how to disable/enable vulnerability detection in the Manager #7337
Closed
sebasfalcone
sebasfalcone previously approved these changes May 28, 2024
View reviewed changes
@sebasfalcone sebasfalcone changed the base branch from 4.9.0 to 4.8.0 May 28, 2024 14:46
@sebasfalcone sebasfalcone dismissed their stale review May 28, 2024 14:46

The base branch was changed.

@sebasfalcone sebasfalcone self-requested a review May 28, 2024 14:46
sebasfalcone
sebasfalcone reviewed May 28, 2024
View reviewed changes
Copy link
Member

@sebasfalcone sebasfalcone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GabrielEValenzuela
Please rebase this into 4.8.0

GabrielEValenzuela and others added 2 commits May 28, 2024 12:06
@GabrielEValenzuela
CL:
dfb4ab0 
- Add missing docs for remediation cache and manager scan.
@sebasfalcone @GabrielEValenzuela
CL:
20d09d1 
- Removed unnecessary changes
@GabrielEValenzuela GabrielEValenzuela force-pushed the enhancement/7336-add-doc-vd-internal-options branch from f9bf10c to 20d09d1 Compare May 28, 2024 15:08
sebasfalcone
sebasfalcone previously approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@sebasfalcone sebasfalcone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebasfalcone sebasfalcone requested a review from javimed May 28, 2024 15:20
@javimed javimed added level/task Task issue type/enhancement Enhancement issue labels May 28, 2024
@GabrielEValenzuela
CL:
ac6b79a 
- Fix review comments.
@GabrielEValenzuela
CL:
263873a 
- Fix review comments.
@sebasfalcone @javimed
CL:
9dd302a 
- Updated description to improve coherence

Co-authored-by: Javier Medeot <javier.medeot@wazuh.com>
@sebasfalcone sebasfalcone requested a review from javimed May 28, 2024 20:53
@javimed javimed merged commit 34b5342 into 4.8.0 May 29, 2024
3 checks passed
@javimed javimed deleted the enhancement/7336-add-doc-vd-internal-options branch May 29, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauldpm rauldpm rauldpm approved these changes

@sebasfalcone sebasfalcone sebasfalcone approved these changes

@javimed javimed javimed approved these changes

Assignees

@GabrielEValenzuela GabrielEValenzuela

Labels
level/task Task issue type/enhancement Enhancement issue
Projects
No open projects
Release 4.8.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing variables in the internal configuration documentation for the Vulnerability Detection module.
4 participants
@GabrielEValenzuela @rauldpm @sebasfalcone @javimed