Refactor try catch in Agent Syscollector/Vuls/Stats #3462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implement try catch groups * Add test * test(groups): Added simple snapshot test. * Add changelog * Change context * Change title Co-authored-by: gabiwassan <gabriel.wassan@wazuh.com>
* fix(syscollector): Fixed dispatch for updateCurrentAgentData * fix(syscollector): Refactor for agents-sections.
* test(unittest): Updating test. * test(unittest): Updating test.
pablomarga
approved these changes
Jul 15, 2021
| this.setState({ | ||
| error: `Data could not be fetched for ${this.props.vulName}`, | ||
| }); | ||
| } finally { |
There was a problem hiding this comment.
This finally statement could be removed?
|
Machi3mfl
pushed a commit
that referenced
this pull request
Jul 19, 2021
* fix(syscollector): Added try catch strategy. * Implement try catch strategy in Groups (#3415) * Implement try catch groups * Add test * test(groups): Added simple snapshot test. * Add changelog * Change context * Change title Co-authored-by: gabiwassan <gabriel.wassan@wazuh.com> * Create Cypress Workflow for 4.3-7.10 (#3444) * Fixed dispatch for updateCurrentAgentData (#3453) * fix(syscollector): Fixed dispatch for updateCurrentAgentData * fix(syscollector): Refactor for agents-sections. * doc(changelog): Updated * Updating test. (#3470) * test(unittest): Updating test. * test(unittest): Updating test. * test(agent-table): Added unit test & fix collectCoverage Co-authored-by: Pablo Martínez <pablo.martinez@wazuh.com> Co-authored-by: Matias Ezequiel Moreno <49887871+matiasmoreno876@users.noreply.github.com>
gabiwassan
added a commit
that referenced
this pull request
Aug 5, 2021
* fix(syscollector): Added try catch strategy. * Implement try catch strategy in Groups (#3415) * Implement try catch groups * Add test * test(groups): Added simple snapshot test. * Add changelog * Change context * Change title Co-authored-by: gabiwassan <gabriel.wassan@wazuh.com> * Create Cypress Workflow for 4.3-7.10 (#3444) * Fixed dispatch for updateCurrentAgentData (#3453) * fix(syscollector): Fixed dispatch for updateCurrentAgentData * fix(syscollector): Refactor for agents-sections. * doc(changelog): Updated * Updating test. (#3470) * test(unittest): Updating test. * test(unittest): Updating test. * test(agent-table): Added unit test & fix collectCoverage Co-authored-by: Pablo Martínez <pablo.martinez@wazuh.com> Co-authored-by: Matias Ezequiel Moreno <49887871+matiasmoreno876@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
This PR implements a new strategy to catch and store/show errors in the Agent Syscollector/Vuls/Stats sections.
Close: #3431