Implement try catch strategy in Groups #3415

pablomarga · 2021-06-30T09:39:11Z

Hi team,
This PR implement our new error handling strategy on the Groups section

gabiwassan · 2021-07-06T12:40:31Z

public/controllers/management/components/management/groups/actions-buttons-agents.js

@@ -72,7 +73,18 @@ class WzGroupsActionButtonsAgents extends Component {
      this.props.updateIsProcessing(true);
      this.onRefreshLoading();
    } catch (error) {
-      return Promise.reject(error);
+      const options = {
+        context: errorContext,


Change this context using ${Class.name}.method and remove const errorContext

gabiwassan · 2021-07-06T12:40:40Z

public/controllers/management/components/management/groups/actions-buttons-agents.js

-    } catch (error) {}
+    } catch (error) {
+      const options = {
+        context: errorContext,


gabiwassan · 2021-07-06T12:41:14Z

public/controllers/management/components/management/groups/actions-buttons-files.js

+        error: {
+          error: error,
+          message: error.message || error,
+          title: error.message || error,


here is error.name

gabiwassan · 2021-07-06T12:41:35Z

public/controllers/management/components/management/groups/actions-buttons-files.js

+        error: {
+          error: error,
+          message: error.message || error,
+          title: error.message || error,


here is error.name || error

gabiwassan · 2021-07-06T12:43:06Z

public/controllers/management/components/management/groups/group-agents-table.js

+import { UI_ERROR_SEVERITIES } from '../../../../../react-services/error-orchestrator/types';
+import { getErrorOrchestrator } from '../../../../../react-services/common-services';
+
+const errorContext = 'WzGroupAgentsTable';


Replace this const for Class.name

gabiwassan

LGTM !

* Implement try catch groups * Add test * test(groups): Added simple snapshot test. * Add changelog * Change context * Change title Co-authored-by: gabiwassan <gabriel.wassan@wazuh.com>

* fix(syscollector): Added try catch strategy. * Implement try catch strategy in Groups (#3415) * Implement try catch groups * Add test * test(groups): Added simple snapshot test. * Add changelog * Change context * Change title Co-authored-by: gabiwassan <gabriel.wassan@wazuh.com> * Create Cypress Workflow for 4.3-7.10 (#3444) * Fixed dispatch for updateCurrentAgentData (#3453) * fix(syscollector): Fixed dispatch for updateCurrentAgentData * fix(syscollector): Refactor for agents-sections. * doc(changelog): Updated * Updating test. (#3470) * test(unittest): Updating test. * test(unittest): Updating test. * test(agent-table): Added unit test & fix collectCoverage Co-authored-by: Pablo Martínez <pablo.martinez@wazuh.com> Co-authored-by: Matias Ezequiel Moreno <49887871+matiasmoreno876@users.noreply.github.com>

* Implement try catch react-services * Changes requested * Change severity to show the toast * Add changelog * Solve comments * Changed all context value of all try-catch implementations (#3432) * refactor(error-orchestrator): Changed all context value of all try-catch implementations * docs(error-orchestrator): Updated changelog. * Implement try catch strategy in Groups (#3415) * Implement try catch groups * Add test * test(groups): Added simple snapshot test. * Add changelog * Change context * Change title Co-authored-by: gabiwassan <gabriel.wassan@wazuh.com> * Create Cypress Workflow for 4.3-7.10 (#3444) * Fixed dispatch for updateCurrentAgentData (#3453) * fix(syscollector): Fixed dispatch for updateCurrentAgentData * fix(syscollector): Refactor for agents-sections. * Fixing and updating unit-tests. (#3413) * test(unit-test): Fixing and updating unit-tests. * test(scheduler-job): Fixing suite scheduler-job tests. * test(unit-test): Fixing updating unit-tests. * test(check-result): Fixing uTest of check-result, added error case. * test(unit-test): Skipped uTest with dependency of API. * test(prettier): Applied prettier, redux-mock-store dependency * test(jest): Jest config without dependencies. * test(git-actions): Added workflow for uTest. * test(check-result): Update workflow. * test(git-actions): Updated workflow * test(gitactions): Dependencies for unit test. * test(gitactions): Added coverage-comment * test(gitactions): Changed text to text-summary * test(gitactions): Show summary * test(gitactions): Show summary + added dependencies * test(gitactions): Typo * test(gitactions): Porcents * test(gitactions): Typo * test(gitactions): Testing node version with yarn * test(gitactions): Update * test(gitactions): Update * test(gitactions): testing coverage summary * test(gitactions): testing coverage summary * test(gitactions): fix param github-token * test(gitactions): update * test(gitactions): testing report.json * test(gitactions): final test. * test(actions): testing kibana dependencies * test(actions): testing kibana dependencies * test(actions): testing kibana dependencies * test(actions): testing kibana dependencies * test(actions): testing * test(actions): testing * test(actions): test with old config jest. * test(actions): set node version for jest * test(actions): testing with bootstrap * test(actions): rollback dependencies * test(actions): rollback * test(groups-main): fixing snapshot test * test(groups-main): added coverage * test(groups-main): fix path * test(groups-main): fix path * test(git-actions): fix script * test(git-actions): fix checkout * test(git-actions): fix checkout * test(git-actions): fix checkout * test(git-actions): fix checkout * test(git-actions): fix checkout * test(git-actions): fix checkout * test(git-actions): fix checkout * test(git-actions): fix checkout * fix(syscollector): Refactor for agents-sections. * fix(syscollector): Clean files. * fix(syscollector): Clean files. * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test comment coverage * fix(syscollector): test comment coverage * fix(syscollector): test comment coverage * fix(actions): test comment coverage * Create Cypress Workflow for 4.3-7.10 (#3444) * Fixed dispatch for updateCurrentAgentData (#3453) * fix(syscollector): Fixed dispatch for updateCurrentAgentData * fix(syscollector): Refactor for agents-sections. * fix(actions): add const env Co-authored-by: Matias Ezequiel Moreno <49887871+matiasmoreno876@users.noreply.github.com> * Added try-catch strategy in Reporting section (#3427) * Implemented new try-catch strategy * Updated context * Added test file and snapshot * Updated CHANGELOG * Requested changes * Removed blank space in message * Updated error title and message Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com> Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com> * Implement/try catch in Components > Overview (#3442) * Techniques and mitre * Resources * Update changelog * Refactor try catch in Management > Statistics (#3429) * Added error handling implementation * Changed wrong var err * Draft statistics test and snapshot * Updated CHANGELOG * Updating title and message error Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com> Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com> * Refactor try catch in Management > Configuration (#3451) * Added new try-catch strategy in Management > Configuration * Updated CHANGELOG * Requested changes * doc(changelog): update Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com> Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com> * Updating test. (#3470) * test(unittest): Updating test. * test(unittest): Updating test. * feat(orchestratorError): Fixed some options for orchestrator and added on app-state * Xpack and odfe tests * Fix test * Add copyright * fix(discover): fix conflict Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com> Co-authored-by: Matias Ezequiel Moreno <49887871+matiasmoreno876@users.noreply.github.com> Co-authored-by: Maximiliano Ibarra <maximilianoaibarra@gmail.com> Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com>

* fix(syscollector): Added try catch strategy. * Implement try catch strategy in Groups (#3415) * Implement try catch groups * Add test * test(groups): Added simple snapshot test. * Add changelog * Change context * Change title Co-authored-by: gabiwassan <gabriel.wassan@wazuh.com> * Create Cypress Workflow for 4.3-7.10 (#3444) * Fixed dispatch for updateCurrentAgentData (#3453) * fix(syscollector): Fixed dispatch for updateCurrentAgentData * fix(syscollector): Refactor for agents-sections. * doc(changelog): Updated * Updating test. (#3470) * test(unittest): Updating test. * test(unittest): Updating test. * test(agent-table): Added unit test & fix collectCoverage Co-authored-by: Pablo Martínez <pablo.martinez@wazuh.com> Co-authored-by: Matias Ezequiel Moreno <49887871+matiasmoreno876@users.noreply.github.com>

* Implement try catch react-services * Changes requested * Change severity to show the toast * Add changelog * Solve comments * Changed all context value of all try-catch implementations (#3432) * refactor(error-orchestrator): Changed all context value of all try-catch implementations * docs(error-orchestrator): Updated changelog. * Implement try catch strategy in Groups (#3415) * Implement try catch groups * Add test * test(groups): Added simple snapshot test. * Add changelog * Change context * Change title Co-authored-by: gabiwassan <gabriel.wassan@wazuh.com> * Create Cypress Workflow for 4.3-7.10 (#3444) * Fixed dispatch for updateCurrentAgentData (#3453) * fix(syscollector): Fixed dispatch for updateCurrentAgentData * fix(syscollector): Refactor for agents-sections. * Fixing and updating unit-tests. (#3413) * test(unit-test): Fixing and updating unit-tests. * test(scheduler-job): Fixing suite scheduler-job tests. * test(unit-test): Fixing updating unit-tests. * test(check-result): Fixing uTest of check-result, added error case. * test(unit-test): Skipped uTest with dependency of API. * test(prettier): Applied prettier, redux-mock-store dependency * test(jest): Jest config without dependencies. * test(git-actions): Added workflow for uTest. * test(check-result): Update workflow. * test(git-actions): Updated workflow * test(gitactions): Dependencies for unit test. * test(gitactions): Added coverage-comment * test(gitactions): Changed text to text-summary * test(gitactions): Show summary * test(gitactions): Show summary + added dependencies * test(gitactions): Typo * test(gitactions): Porcents * test(gitactions): Typo * test(gitactions): Testing node version with yarn * test(gitactions): Update * test(gitactions): Update * test(gitactions): testing coverage summary * test(gitactions): testing coverage summary * test(gitactions): fix param github-token * test(gitactions): update * test(gitactions): testing report.json * test(gitactions): final test. * test(actions): testing kibana dependencies * test(actions): testing kibana dependencies * test(actions): testing kibana dependencies * test(actions): testing kibana dependencies * test(actions): testing * test(actions): testing * test(actions): test with old config jest. * test(actions): set node version for jest * test(actions): testing with bootstrap * test(actions): rollback dependencies * test(actions): rollback * test(groups-main): fixing snapshot test * test(groups-main): added coverage * test(groups-main): fix path * test(groups-main): fix path * test(git-actions): fix script * test(git-actions): fix checkout * test(git-actions): fix checkout * test(git-actions): fix checkout * test(git-actions): fix checkout * test(git-actions): fix checkout * test(git-actions): fix checkout * test(git-actions): fix checkout * test(git-actions): fix checkout * fix(syscollector): Refactor for agents-sections. * fix(syscollector): Clean files. * fix(syscollector): Clean files. * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test * fix(syscollector): test comment coverage * fix(syscollector): test comment coverage * fix(syscollector): test comment coverage * fix(actions): test comment coverage * Create Cypress Workflow for 4.3-7.10 (#3444) * Fixed dispatch for updateCurrentAgentData (#3453) * fix(syscollector): Fixed dispatch for updateCurrentAgentData * fix(syscollector): Refactor for agents-sections. * fix(actions): add const env Co-authored-by: Matias Ezequiel Moreno <49887871+matiasmoreno876@users.noreply.github.com> * Added try-catch strategy in Reporting section (#3427) * Implemented new try-catch strategy * Updated context * Added test file and snapshot * Updated CHANGELOG * Requested changes * Removed blank space in message * Updated error title and message Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com> Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com> * Implement/try catch in Components > Overview (#3442) * Techniques and mitre * Resources * Update changelog * Refactor try catch in Management > Statistics (#3429) * Added error handling implementation * Changed wrong var err * Draft statistics test and snapshot * Updated CHANGELOG * Updating title and message error Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com> Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com> * Refactor try catch in Management > Configuration (#3451) * Added new try-catch strategy in Management > Configuration * Updated CHANGELOG * Requested changes * doc(changelog): update Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com> Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com> * Updating test. (#3470) * test(unittest): Updating test. * test(unittest): Updating test. * feat(orchestratorError): Fixed some options for orchestrator and added on app-state * Xpack and odfe tests * Fix test * Add copyright * fix(discover): fix conflict Co-authored-by: Gabriel Wassan <gabriel.wassan@wazuh.com> Co-authored-by: Matias Ezequiel Moreno <49887871+matiasmoreno876@users.noreply.github.com> Co-authored-by: Maximiliano Ibarra <maximilianoaibarra@gmail.com> Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com>

Implement try catch groups

8c35e59

pablomarga added the error-handling label Jun 30, 2021

pablomarga requested a review from a team June 30, 2021 09:39

pablomarga self-assigned this Jun 30, 2021

pablomarga marked this pull request as draft June 30, 2021 09:39

pablomarga and others added 2 commits July 5, 2021 15:50

Add test

bd48969

test(groups): Added simple snapshot test.

4703adc

pablomarga marked this pull request as ready for review July 5, 2021 16:08

pablomarga and others added 2 commits July 6, 2021 10:08

Add changelog

a1a8172

Merge branch '4.3-7.10' into implement/try-catch-groups

586ab6c

gabiwassan suggested changes Jul 6, 2021

View reviewed changes

pablomarga added 2 commits July 6, 2021 16:29

Change context

e28d5be

Change title

9b2cf4a

gabiwassan approved these changes Jul 6, 2021

View reviewed changes

gabiwassan merged commit a3433bc into 4.3-7.10 Jul 7, 2021

gabiwassan deleted the implement/try-catch-groups branch July 7, 2021 21:14

MauGaP mentioned this pull request Nov 30, 2021

Release 4.3.0 - Release Candidate 1 - Kibana UI regression testing #3684

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement try catch strategy in Groups #3415

Implement try catch strategy in Groups #3415

pablomarga commented Jun 30, 2021

gabiwassan Jul 6, 2021

gabiwassan Jul 6, 2021

gabiwassan Jul 6, 2021

gabiwassan Jul 6, 2021

gabiwassan Jul 6, 2021

gabiwassan left a comment

Implement try catch strategy in Groups #3415

Implement try catch strategy in Groups #3415

Conversation

pablomarga commented Jun 30, 2021

gabiwassan Jul 6, 2021

Choose a reason for hiding this comment

gabiwassan Jul 6, 2021

Choose a reason for hiding this comment

gabiwassan Jul 6, 2021

Choose a reason for hiding this comment

gabiwassan Jul 6, 2021

Choose a reason for hiding this comment

gabiwassan Jul 6, 2021

Choose a reason for hiding this comment

gabiwassan left a comment

Choose a reason for hiding this comment