-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/3489 query config refactor #3490
Fix/3489 query config refactor #3490
Conversation
@@ -16,7 +16,8 @@ import { MainPanel } from '../../../components/common/modules/panel'; | |||
import { withErrorBoundary } from '../../common/hocs'; | |||
import { ModuleStats } from './module-stats'; | |||
import { WzRequest } from '../../../react-services/wz-request'; | |||
import { queryConfig } from '../../../services/query-config'; | |||
//import { queryConfig } from '../../../services/query-config'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove commented import
@@ -16,7 +16,8 @@ import { MainPanel } from '../../../components/common/modules/panel'; | |||
import { withErrorBoundary } from '../../common/hocs'; | |||
import { ModuleStats } from './module-stats'; | |||
import { WzRequest } from '../../../react-services/wz-request'; | |||
import { queryConfig } from '../../../services/query-config'; | |||
//import { queryConfig } from '../../../services/query-config'; | |||
import { queryConfig } from '../../../react-services/query-config'; | |||
import { getCurrentConfig } from '../../../controllers/management/components/management/configuration/utils/wz-fetch'; | |||
// import { getCurrentConfig } from '../../../react-services'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove commented import
@@ -16,7 +16,8 @@ import { MainPanel } from '../../../components/common/modules/panel'; | |||
import { withErrorBoundary } from '../../common/hocs'; | |||
import { ModuleStats } from './module-stats'; | |||
import { WzRequest } from '../../../react-services/wz-request'; | |||
import { queryConfig } from '../../../services/query-config'; | |||
//import { queryConfig } from '../../../services/query-config'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please remove the comments to improve code readability?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: Besides cleaning some comments, looks good to me ✔️
ac11be0
into
feature/create-modular-view-office365-github-3422
Hi guys,
In this PR refactor query Config from Angular to React
To prove it,
We enter the new Office 365 section, click on the Panel tab and click on the i at the top left, which will display the panel. It should not give us any error in console.
Close: #3489