Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module] [GitHub] Add the module #3557

Merged
merged 247 commits into from
Nov 15, 2021
Merged

[Module] [GitHub] Add the module #3557

merged 247 commits into from
Nov 15, 2021

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Aug 10, 2021

This PR adds the GitHub module to the app.

Features

  • Add access to the module on the main and agent menu and Modules directory
  • Let to configure the module visibility on Settings/Modules
  • Add configuration viewer on (Management/Agent)/Configuration for managers and agents
  • Add sample data
  • Add the tabs to explore the data on Modules
    • Dashboard: created and added the visualizations
    • Events
    • Panel
      • views:
        • main (4 tables with Elasticsearch aggregations) and access to 4 drills down (one for each table)
        • 4 drill down (user, organization, repository, action) with visualizations and events table
      • module information: display the configuration for the module taking into account if there is some agent pinned or not
      • implementation of the custom search bar (simple and advanced mode)

Screenshots

To be completed

Dashboard
image

Sample data
image
image

Tests

To be decided

To test it

  1. Go to Github
  • Given the browser is logged in the Wazuh kibana app
  • When the user navigate to Modules -> GitHub -> any of the sections of Github
  • Then the visualizations and tables will be displayed properly and without any errors

TODO

  • Replace the current selectors to use the new MultiSelect component, which is used on the Office 365 module. This should be done after the implementation on the Office 365 branch is completed

Closes #3372

Desvelao and others added 30 commits June 24, 2021 11:01
  - Add logic to generate alerts for the module
  - Add GitHub to the Secutiry events description in Settings > Sample data
  - Enable GitHub sample data for the Security events category
UI
  - Add GitHub module to the main menu under Modules > Security information management
  - Add GitHub module to the agent menu under Modules > Security
information menu
  - Add Github module to configure visibility in Settings > Modules
  - Add Github module to the Modules directory
  - Add basic structure of GitHub module with tabs Audit logs, Dashboard and
Events
…sing componente property

  - Fix a missing component property in the component to update the agent data
…ons to the GitHub module

  - Add visualizations for overview and agents
  - Add metrics to the module for the count of Organizations, Repositories and Actors
  - Removed not necessary /server/integration-files/visualizations/agents/index.js file because there is a .ts file
It seems to be called 5 times every time for some reason
Need to test the preApplied parammeters and add pagination functions
@frankeros
Copy link
Contributor

frankeros commented Aug 10, 2021

The tables of all drill downs in GitHub are broken

Fixed

Desvelao and others added 12 commits August 11, 2021 09:02
  - Fix the module description in the `Modules directoy`
…table of each drill down view (#3560)

* fix(module_office365): Add `rule.level` and `rule.id` field to drilldown tables in the `Panel` tab

* fix(module_office365): Move the column of `rule.description` in the alerts table of the Panel drill down views
* Looking for errors

* check for agentList length

* check for agentList length

* check for agentList length

* fix: remove tooltip for agent pinned and add hoc for events in office

* fix: unppin agent from botton doesn't work

* fix(module_office): Avoid building the agents visualizations for the Office 365 module
  - Moved the handle error to upper function instead of the service `VisFactoryHandler`

* Resolving unpin agent in office panel

Co-authored-by: Franco Charriol <francocharriol@gmail.com>
Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com>
Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com>
* block filter when drilldown is open

* fix PR comments

* feat: disable entire botton of multiselect on is disabled

Co-authored-by: Franco Charriol <francocharriol@gmail.com>
@frankeros frankeros marked this pull request as ready for review August 11, 2021 20:06
@Desvelao
Copy link
Member Author

Changes

  • Updated the branch with the last changes of feature/Office365
  • Add the render of missing spacers as the api_auth is displayed

* Simple filters change between panel and drilldown panel

* Adding Changelog

* Adding type to boolFilter

* Rename filterDrillDownValue to boolFilterValue

* Fixing simple filters

* Adding default value to boolFilter

* Sort suggested values alphabetically and by selected

Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
@CPAlejandro
Copy link
Contributor

CPAlejandro commented Nov 11, 2021

Solved problem found in Office 365/Events:
image (7)

The problem is that the Events columns are not declared in Office and Github.

This is the result:

Office:
image (8)

Github:
image

@CPAlejandro CPAlejandro merged commit 75d4289 into 4.3-7.10 Nov 15, 2021
@CPAlejandro CPAlejandro deleted the feat/3372-github-module branch November 15, 2021 08:55
@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 3.98% ( 1443 / 36286 )
Branches 1.6% ( 453 / 28324 )
Functions 2.92% ( 259 / 8881 )
Lines 4.03% ( 1398 / 34674 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Enhancement issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New section for GitHub module
8 participants