Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The creation of the base is integrated within the script build_packages.sh #1831

Merged
merged 7 commits into from Sep 7, 2022
Merged

The creation of the base is integrated within the script build_packages.sh #1831

merged 7 commits into from Sep 7, 2022

Conversation

c-bordon
Copy link
Member

@c-bordon c-bordon commented Sep 2, 2022 •
edited by rauldpm

Related issue
Related https://github.com/wazuh/wazuh-jenkins/issues/3898

Description

Changes are made in the build_packages.sh, a call is integrated so that the base is generated locally and both the base and the package are built in the same execution

Logs example

-rw-r--r--  1 root    root    141650768 sep  2 16:29 wazuh-dashboard_4.4.0-1_amd64.deb
-rw-r--r--  1 root    root          164 sep  2 16:29 wazuh-dashboard_4.4.0-1_amd64.deb.sha512
-rw-r--r--  1 root    root    172479728 sep  2 16:20 wazuh-dashboard-4.4.0-1.x86_64.rpm
-rw-r--r--  1 root    root          165 sep  2 16:20 wazuh-dashboard-4.4.0-1.x86_64.rpm.sha512
-rw-r--r--  1 root    root    126598524 sep  2 16:27 wazuh-dashboard-base-4.4.0-1-linux-x64.tar.xz
-rw-r--r--  1 root    root    126602520 sep  2 12:52 wazuh-dashboard-base-99.99.0-1-linux-x64.tar.xz
-rw-r--r--  1 root    root    126591984 sep  2 13:15 wazuh-dashboard-base-99.99.0-2-linux-x64.tar.xz
-rw-r--r--  1 root    root    392200282 sep  2 16:44 wazuh-indexer_4.4.0-1_amd64.deb
-rw-r--r--  1 root    root          162 sep  2 16:44 wazuh-indexer_4.4.0-1_amd64.deb.sha512
-rw-r--r--  1 root    root    414535196 sep  2 16:53 wazuh-indexer-4.4.0-1.x86_64.rpm
-rw-r--r--  1 root    root          163 sep  2 16:53 wazuh-indexer-4.4.0-1.x86_64.rpm.sha512
-rw-r--r--  1 root    root    393219320 sep  2 16:07 wazuh-indexer-base-4.3.8-1-linux-x64.tar.xz
-rw-r--r--  1 root    root    393199248 sep  2 16:50 wazuh-indexer-base-4.4.0-1-linux-x64.tar.xz

Tests

  • Build the package in any supported platform
    • Linux
    • Windows
    • macOS
    • Solaris
    • AIX
    • HP-UX
  • Package installation
  • Package upgrade
  • Package downgrade
  • Package remove
  • Package install/remove/install
  • Change added to CHANGELOG.md
  • Tests for Linux RPM
    • Build the package for x86_64
    • Build the package for i386
    • Build the package for armhf
    • Build the package for aarch64
    • %files section is correctly updated if necessary
  • Tests for Linux deb
    • Build the package for x86_64
    • Build the package for i386
    • Build the package for armhf
    • Build the package for aarch64
    • Package install/remove/install
    • Package install/purge/install
    • Check file permissions after installing the package
  • Tests for macOS
    • Test the package from macOS Sierra to Mojave
  • Tests for Solaris
    • Test the package on Solaris 10
    • Test the package on Solaris 11
    • Check file permissions on Solaris 11 template
  • Tests for IBM AIX
    • %files section is correctly updated if necessary
    • Check the changes from IBM AIX 5 to 7

@c-bordon c-bordon self-assigned this Sep 2, 2022
@c-bordon c-bordon changed the title Integrate a call inside build_package.sh The creation of the base is integrated within the script build_packages.sh Sep 2, 2022
rauldpm
rauldpm approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@rauldpm rauldpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DFolchA
DFolchA reviewed Sep 7, 2022
View reviewed changes
stack/indexer/deb/builder.sh
@@ -8,15 +8,14 @@
# License (version 2) as published by the FSF - Free Software
# Foundation.

set -ex
set -e
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing the -x?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the x argument to keep the same options as in the rest of the stack scripts

DFolchA
DFolchA approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@DFolchA DFolchA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@okynos okynos merged commit 7cd6990 into 4.4 Sep 7, 2022
@okynos okynos deleted the 3898-IntegrateBaseCreation-to4.4 branch September 7, 2022 11:46
@c-bordon c-bordon mentioned this pull request Sep 23, 2022
Merged
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okynos okynos okynos approved these changes

@rauldpm rauldpm rauldpm approved these changes

@DFolchA DFolchA DFolchA approved these changes

@fcaffieri fcaffieri Awaiting requested review from fcaffieri

Assignees

@c-bordon c-bordon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@c-bordon @okynos @rauldpm @DFolchA