Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace launchctl variables from macOS installation scripts #2218

Merged
merged 2 commits into from May 24, 2023

Conversation

DFolchA
Copy link
Contributor

@DFolchA DFolchA commented May 24, 2023

Related issue
#2205

Description

This PR removes the execution of launchctl commands from macOS installation scripts.

This PR must be merged in combination with:
wazuh/wazuh#17195

Logs example

Tests

#2205 (comment)

@DFolchA DFolchA self-assigned this May 24, 2023
@DFolchA DFolchA changed the title Replace launchctl variables with temporary files Replace launchctl variables from macOS installation scripts May 24, 2023
Copy link
Contributor

@verdx verdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

macos/package_files/postinstall.sh Outdated Show resolved Hide resolved
macos/package_files/preinstall.sh Outdated Show resolved Hide resolved
macos/package_files/postinstall.sh Outdated Show resolved Hide resolved
@jnasselle jnasselle linked an issue May 24, 2023 that may be closed by this pull request
2 tasks
@teddytpc1 teddytpc1 merged commit 8c1d2fe into 4.4.3 May 24, 2023
@teddytpc1 teddytpc1 deleted the 2205-remove-launchctl branch May 24, 2023 14:43
@rauldpm rauldpm restored the 2205-remove-launchctl branch May 24, 2023 14:46
@vikman90 vikman90 deleted the 2205-remove-launchctl branch May 24, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot install macOS package on macOS Ventura 13.4
4 participants