Adapt wazuhapp and Wazuh dashboard to install the Wazuh CheckUpdates and Core plugins #2609
Conversation
| echo -e " $(basename "$0") - Build Wazuh dashboard base file." | ||
| echo -e "" | ||
| echo -e "SYNOPSIS" | ||
| echo -e " $(basename "$0") -a | -m | -u | -c | -s | -b | -f | -r | -h" |
There was a problem hiding this comment.
Nitpick: only short options are listed, long ones are not mentioned
There was a problem hiding this comment.
This is the expected output as it was decided a long time ago, the same applies to the OVA and other packages that have been updated before this change, this was a decision from the management team.
https://github.com/wazuh/wazuh-packages/blob/master/ova/generate_ova.sh#L33-L61
| echo -e " -r, --revision <rev>" | ||
| echo -e " [Optional] Package revision." | ||
| echo -e "" | ||
| echo -e " -c, --checksum <path>" | ||
| echo -e " [Optional] Generate checksum." |
There was a problem hiding this comment.
nitpick: default behavior missing
There was a problem hiding this comment.
Same, the default value was removed unless it was necessary to the user (as the output directory)
| npm install -g n | ||
| npm install -g n | ||
|
|
||
| RUN yum install -y \ |
There was a problem hiding this comment.
Any reason to keep this in a separate RUN command?
There was a problem hiding this comment.
Actually, no, I didn't see the other yum install, but this dependency is not necessary to build the package itself but to configure the packages names, I think it should be separately
Description
This pull request adapts the APP and Wazuh dashboard packages creation according to the new Wazuh plugins
Logs example
See #2589 (comment)
Tests