Fix the Wazuh agent installation on Windows #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Format the params_agent.pp file + Add an optional agent_service_ensure parameter to control the service status + Download the Wazuh Windows agent MSI file to C:\Temp (fixes #73) ! Use the right parameters for the Windows agent MSI + Add the support for a registration password for the Windows agent + Add the support for Windows in ossec.conf generation concats * Make sure we generate the ossec.conf file before starting the Wazuh service + Setup the Wazuh service on Windows (was only called on Linux) * Extract agent parameters common to both Linux and Windows out of the Linux case + Add the missing parameters for the Windows agent - Remove all the parameters that are not relevant for agents from the params_agent.pp file
|
Hi @JPLachance! Great work here, I had a look at changes and they look good. We will test it as soon as possible, we will verify the following checks: Tests
Thanks for such a big contribution, it's really appreciated. Best regards, Jose |
* Make it clear that both "Manager verification using SSL" and "Agent verification using SSL" are not supported on Windows
|
Hi @JPLachance, Please ignore the failed result on tests, we are working on it and sometimes it shows false positives results. Just reviewed the latest changes from 1f8ab30 and they look great! Thanks for such a big contribution! Best regards, Jose |
manuasir
approved these changes
Oct 28, 2019
! Fix the Wazuh agent MSI download path
jm404
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wazuh agent on Windows
Why did I open this PR
I need to deploy Wazuh agents on Windows instances. I rapidly figured out that this Puppet module was not ready for Windows, so I fixed it!
Changes
+ Add an optional agent_service_ensure parameter to control the service status
+ Download the Wazuh Windows agent MSI file to
C:\Temp(fixes #73)! Use the right parameters for the Windows agent MSI (based on the official documentation)
+ Add the support for a registration password for the Windows agent
! Fix the agent package ensure loop on Windows (Windows sais 3.10.2 is installed, but Puppet wants 3.10.2-1, so Puppet was re-installing it at every run)
+ Add the support for Windows in
ossec.conf generation concats* Make sure we generate the
ossec.conffile before starting the Wazuh service (abeforewas missing, causing the service to start before theossec.confsetup)+ Setup the Wazuh service on Windows (was only called on Linux, I replaced the faulty
ifby a swith case)* Extract agent parameters common to both Linux and Windows out of the Linux case
+ Add the missing parameters for the Windows agent
- Remove all the parameters that are not relevant for agents from the params_agent.pp file
* Format the agent.pp file
* Format the params_agent.pp file
Disclamer
I'm not a Puppet expert! Feel free to request any changes 馃檪