Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive Filebeat module #545

Merged
merged 2 commits into from
Aug 17, 2022

Conversation

poloz-lab
Copy link
Contributor

Fixes #544 .

This PR makes the wazuh::oss_filebeat class use the archive resource to manage the Wazuh Filebeat module.

I'm not sure how to write the dependency for the Puppet archive module.
Also not sure about the version compatibility.

Tested with Puppet 6.27.0 with archive module version 3.0.0 on Debian 10 machines.

source => "https://packages.wazuh.com/4.x/filebeat/${$wazuh_filebeat_module}",
extract => true,
extract_path => '/usr/share/filebeat/module',
creates => '/usr/share/filebeat/module/wazuh',
Copy link
Contributor

@cruelsmith cruelsmith Aug 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also set the cleanup flag to true so the downloaded file will be removed and only be downloaded again when we need it.

Suggested change
creates => '/usr/share/filebeat/module/wazuh',
creates => '/usr/share/filebeat/module/wazuh',
cleanup => true,

Edit: ok it is default but we should set it here 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, it's more explicit like that

@poloz-lab poloz-lab force-pushed the feature-544-archive-filebeat-module branch from 8db0032 to 4febd3b Compare August 8, 2022 12:04
@vcerenu vcerenu self-assigned this Aug 16, 2022
Copy link
Member

@vcerenu vcerenu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @poloz-lab

Thanks for your patience and contribution. We are working hard to review all the requests as soon as possible. Currently, we are reviewing this PR.

The development of this PR is greatly appreciated, we will be merging it and it will be available in the next Wazuh release.

Thank you very much and if you have any questions or ideas, do not hesitate to contact us.

@alberpilot alberpilot merged commit 7585c25 into wazuh:4.3 Aug 17, 2022
@alberpilot
Copy link
Contributor

Thanks, @poloz-lab @cruelsmith for your contribution.

@poloz-lab poloz-lab deleted the feature-544-archive-filebeat-module branch September 1, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants