JVM option memory #547
Merged
JVM option memory #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
poloz-lab
force-pushed
the
fix-546-JVM-memory
branch
from
5167849
to
08c3e0e
Compare
vcerenu
approved these changes
Aug 9, 2022
There was a problem hiding this comment.
Hello @poloz-lab
Thanks for your patience and contribution. We are working hard to review all the requests as soon as possible. Currently, we are reviewing this PR.
The development of this PR is greatly appreciated, we will be merging it and it will be available in the next Wazuh release.
Thank you very much and if you have any questions or ideas, do not hesitate to contact us.
okynos
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #546 .
This PR use file_lines resources to change the -Xms and -Xmx values in the
jvm.optionsfiles.Before, the parameter jvm_options_memmory in wazuh::indexer class had no effect to the JVM.
Tested with Puppet 6.27.0 on a Debian 10 machine.