-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use multiple protocols in windows deployment variables #3400
Comments
Tester review
Testing environment
Conclusion 🔴
Status |
Testing results 🔴List of Deployment variables for each OS
Multiple addresses and protocols 🔴
All deployment variables at the same time with multiple addresses 🔴
All deployment variables at the same time with multiple addresses and protocols 🔴
Test each deployment variable individually: WAZUH_MANAGER 🔴
Test each deployment variable individually: WAZUH_MANAGER_PORT 🟢
Test each deployment variable individually: WAZUH_PROTOCOL 🟢
Test each deployment variable individually: WAZUH_REGISTRATION_SERVER 🟢
Test each deployment variable individually: WAZUH_REGISTRATION_PORT 🟢
Test each deployment variable individually: WAZUH_REGISTRATION_PASSWORD 🟢
Test each deployment variable individually: WAZUH_KEEP_ALIVE_INTERVAL 🟢
Test each deployment variable individually: WAZUH_TIME_RECONNECT 🟢
Test each deployment variable individually: WAZUH_REGISTRATION_CA 🟢
Test each deployment variable individually: WAZUH_REGISTRATION_CERTIFICATE 🟢
Test each deployment variable individually: WAZUH_REGISTRATION_KEY 🟢
Test each deployment variable individually: WAZUH_AGENT_NAME 🟢
Test each deployment variable individually: WAZUH_AGENT_GROUP 🟢
Test each deployment variable individually: ENROLLMENT_DELAY 🟢
Test each deployment variable individually: /l installer.log 🟢
Test each deployment variable individually: /l*v installer.log 🟢
Test deployment variables using multiple addresses and 1 protocol 🔴
Test deployment variables using 1 address and multiple protocols 🔴
Test deployment variables using 1 address and 1 protocol. 🔴
|
QA review
This will be discussed with the development team in order to request the new proposed changes. |
After talking with the CICD team, it has been decided that (1), (2) and (3) (related to the network of the tested development) will be reviewed and fixed in this own development. Regarding (4), (5), (6), (7) we will investigate if there are previously reported issues, and in case there are not they will be opened to be fixed in the future (it is not a stopper to approve the tested development). |
Testing after requested changesResults 🔴Multiple addresses and protocols 🔴Unexpected message during installation in AmazonLinux and Ubuntu OS:
Test deployment variables using multiple addresses and 1 protocol 🔴Wazu agent installation failed for Windows OS
Duplicate manager 🔴If duplicated managers are provided in
|
UpdateAfter meeting with @Rebits and @alberpilot we decided on the following |
Testing after requested changes
Conclusions:
Multiple addresses and protocols. 🟢
Test deployment variables using multiple addresses and 1 protocol 🟢
Duplicate manager - Different protocols 🟢
Duplicate manager - Same protocols 🔴
All deployment variables at the same time with multiple addresses 🟢
All deployment variables at the same time with multiple addresses and protocols 🟢
Test each deployment variable individually: WAZUH_MANAGER 🔴
Test deployment variables using multiple addresses and 1 protocol 🟢
Test deployment variables using 1 address and multiple protocols 🟢
Test deployment variables using 1 address and 1 protocol 🟢
|
…ting uniques Reported here: wazuh/wazuh-qa#3400 (comment)
Update - 24/10/2022 |
…ting uniques Reported here: wazuh/wazuh-qa#3400 (comment)
Testing after requested changes
Results 🔴Multiple addresses and protocols 🟢
Test deployment variables using multiple addresses and 1 protocol 🟢
Duplicate manager - Different protocols 🟢
Duplicate manager - Same protocols 🔴
Conclusion 🔴
|
Update - 04/11/2022After talking with @DFolchA we have proposed removing duplicated managers for the same protocols using the following logic
|
Update - 04/11/2022 |
Testing after requested changes 🔴
ResultsMultiple addresses and protocols 🟢
Test deployment variables using multiple addresses and 1 protocol 🟢
Duplicated manager - Different protocols 🟢
Duplicated manager - Same protocols 🟢
All deployment variables at the same time with multiple addresses 🟢
Test each deployment variable individually: WAZUH_MANAGER 🟢
Test deployment variables using 1 address and 1 protocol 🟢
Test deployment variables using 1 address and multiple protocols 🟢
Windows/Linux deployment configuration differs using the same deployment variables 🔴While in Linux agent |
Update - 07/11/2022 |
List of not development-related unexpected behaviors
List of fixed unexpected behaviors not development-related
|
Testing after requested changes 🟢
ResultsWindows/Linux deployment configuration is consistent 🟢Windows and Ubuntu agent configurations are consistent.Command: Ubuntu:
Windows:
|
Closing conclusion 👍🏼
The development has been approved taking into account the following considerations: (1) The values of WAZUH_MANAGER do not follow the specified order, causing inconsistencies. 🟢 Installation using the WAZUH_MANAGER variable with multiple values causes blocks to be inserted in an unexpected order, causing the protocols and manager addresses to not match as expected. This occurs for Linux and macOS agents. This has been fixed in this current development (2) WAZUH_PROTOCOL values cause multiple blocks to be inserted in Windows agents, potentially causing unwanted behavior 🟢 This has been solved in this current development wazuh/wazuh@f07df8f (3) If we specify more values for WAZUH_MANAGER variable than > WAZUH_PROTOCOL, then wazuh-agent installation fails for Windows 🟢 This has been solved in this current development wazuh/wazuh@50c5c11 (4) New Warning during agent installation in Ubuntu ⚫ This was previously investigated in this issue wazuh-packages#1709 and this seems to be related to (5) Windows Server 2022 default configuration does not include any config-profile 🔵 The following issue has been opened to report this wazuh#15150. It will be fixed for future versions. (6) Default manager IP mismatch for Linux and macOS agents (MANAGER_IP) from Windows (0.0.0.0) 🔵 The following issue has been opened to report this wazuh#15154. It will be fixed for future versions. (7) Warning during Ubuntu agent uninstallation using apt-get remove wazuh-agent 🔵
This also happens in the production version. The following issue has been opened to report this wazuh-packages#1879. It will be investigated and probably fixed for future versions. (8) Unexpected message during installation in AmazonLinux and Ubuntu OS 🟢
This has been solved in this current development wazuh/wazuh@7b05541 (9) If duplicated managers are provided in WAZUH_MANAGER, the configuration will include duplicate configuration. 🟢 This has been solved in this current development wazuh/wazuh@7d38f36 (10) While in Linux agent enrollment configuration block is always specified, in Windows agent if default values are not changed, no configuration is specified 🟢 This has been solved in this current development wazuh/wazuh@7450895 (11) Enrollment configuration block indentation is incorrect for Windows agents 🔵 The following issue has been opened to report this wazuh#15324. It will be fixed for future versions. (12) If a previous agent installation was performed, and only binaries were removed (apt-get remove), the new agent installation will set the default configuration independently of the parameters specified ⚫ After talking with the development team, this is a normal behavior since the OS considers that it is an upgrade if it is not uninstalled with |
* Add support to multiple ptotocols in deployment vars * Use bash arrays to set addresses and protocols * Allow list of protocols for deployment variables * Remove legacy fixes * Add workflow for github actions * Add ubuntu test * Improve register_configure_agent * Add Windows test script * Improve windows deployment variables script * Add macos test * Allow using WAZUH_PROTOCOL variable without WAZUH_MANAGER * Fix github actions workflow * Increase wait timeout * Add timeoutSeconds to Wait for build step * Fail when time out is reached * Change task name * Fix Windows and macOS tests issues * Improve test function * Apply shellcheck recomendations * Add lines at start and end of functions * Remove date in copyright and fix path * Fix condition in Installerscripts.vbs: - Caused error when using more WAZUH_MANAGER values than WAZUH_PROTOCOL * Only remove non-unique WAZUH_MANAGER values if it does not affect to protocol order * Remove addition of second protocol line from InstallerScripts.vbs * Show downloaded package in tests * Correctly place profile template * Fix issues in deployment scripts. - Reported in wazuh/wazuh-qa#3400 (comment) * Generate unique ip lists when conditions are met - See conditions here: #14532 (comment) * Fix error causing protocol to not be set when to TCP #14532 * Fix error showing repeated block when using repeated IP and no protocol * Avoid empty addresses and make protocol list lowercase before calculating uniques Reported here: wazuh/wazuh-qa#3400 (comment) * Fix array index error * Keep order when calculating unique elements * Avoid setting WAZUH_REGISTRATION_SERVER if not specified
Description
In this issue, we have added a feature that allows the users to add multiple protocol types when using the deployment variables. This needs manual testing to validate it.
Proposed checks
This tests must be performed on Linux, Windows and macOS systems.
Steps to reproduce
Expected results
After the installation, the configuration in
ossec.conf
should be the correct one for the deployment variables used.Configuration and considerations
The text was updated successfully, but these errors were encountered: