-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timeout for remoted socket to be ready in test_request_agent_info.py
#1624
Add timeout for remoted socket to be ready in test_request_agent_info.py
#1624
Conversation
refac: Delete six redundant use cases Closes: #1579
Test Execution - ResultsDescriptionTest results with the default configuration modules in the
|
{'PROTOCOL': 'udp,tcp'}, | ||
{'PROTOCOL': 'tcp'}, | ||
{'PROTOCOL': 'udp'}, | ||
{'PROTOCOL': 'udp,tcp'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we should keep all the possible combinations of protocols that we have now since Wazuh 4.2. Before this version, the manager only accepted connections using only one protocol, but now it accepts both, TCP and UDP simultaneously.
This is just a suggestion so we can discuss this in our daily meeting to make a general decision for all the tests that have single protocols and a combination of them.
Test Execution - Results
Could @mdengra execute this again, please? I would like to see if you have the same error. In case that you can't reproduce the fail, tell me and I will put my approval. |
2021-07-22Test Execution - ResultsTest results with the default configuration modules in the
Hello @damarisg, I have rerun the tests but I have not been able to reproduce the error in my test environment. |
Test Execution - ResultsTest results with the default configuration modules in the
|
Description
This PR modifies the
test_request_agent_info.py
ofremoted
tests to add a timeout forremoted
socket to be ready. This timeout is only added in a specific use case, which is where the errors occur.The number of use cases has also been reduced from nine to three, as those eliminated were redundant.
Finally, the documentation has been updated to include the above changes.
Configuration options
All the tests are run with the default configuration and the following options in
local_internal_options.conf
Tests
The comments will have the description for every test run