Mark use of MD5 in Azure integration as false positive #2338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 14, 2021
Rebits
approved these changes
Dec 21, 2021
There was a problem hiding this comment.
LGTM
Reason specified in the conclusion of the research seems to be consistent enough to discard this positive as a code flaw.
test_python_flaws.py
| R | Status |
|---|---|
| R1 | 🟢 |
| R2 | 🟢 |
| R3 | 🟢 |
- 🟢: All pass
- 🟡: Some warnings
- 🔴: Some errors/fails
- 🔵: In progress
davidjiglesias
deleted the
feature/2330-mark-false-positive-using-md5-wodles
branch
mcarmona99
pushed a commit
that referenced
this pull request
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the investigation made in wazuh/wazuh#10116, we concluded that the use of the MD5 hashing algorithm that's being made in the Azure integration doesn't incur in a security flaw, and therefore in this PR we are marking it as a false positive for the
test_python_flaws.pytest.Tests