Add new packages to some cases in E2E VD tests #5349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santipadilla
previously approved these changes
May 8, 2024
|
Please update the changelog |
santipadilla
approved these changes
May 9, 2024
|
LGTM |
juliamagan
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add new packages to the test cases in E2E Vulnerability Detection tests and fix one of them by adding a precondition to resolve the setup problem. The test cases are
upgrade_package_add_vulnerabilityandupgrade_package_maintain_add_vulnerability.Testing performed
The E2E test was launched in an environment consisting of a manager and a MacOS agent. In the report generated if we look at
manager1alert.jsonwe can see that the alerts have been generated and inalerts_found_in_indexwe can see the vulnerabilities detected in the index although they are duplicated. In short, the test is working correctly but it is failing due to a known issue that will be incorporated in the next stage and due to a product issue related to duplicate vulnerabilities.report.zip