Check 'client.keys' existence after deletion in agentd integration test #5429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbertoldo
force-pushed
the
fix/23465-windows-agentd-integration-tests-fails-for-480-rc2
branch
from
7991cb1
to
7cf1f62
Compare
nbertoldo
force-pushed
the
fix/23465-windows-agentd-integration-tests-fails-for-480-rc2
branch
from
7cf1f62
to
1cbc994
Compare
|
Closing this PR as wazuh/wazuh#23465 is closed. |
vikman90
deleted the
fix/23465-windows-agentd-integration-tests-fails-for-480-rc2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It has been seen in wazuh/wazuh#23465 that randomly fails the
test_agentd_reconection_enrollment_no_keys_file.Although it could not be replicated, it is observed in the logs that apparently 'client.keys' file is not being deleted. This causes the agent to connect directly to the manager (with the valid key) skipping the enrollment process and so the test fails.
This PR adds an extra check after deleting 'client.keys' file and in case the file exists an exception is raised.
Updated
tests/integration/test_agentd/test_agentd_reconnection.pyTesting performed
tests\integration\test_agentdtests\integration\test_agentdtests\integration\test_agentd