Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perdition (imap/pop3 proxy) rule #407

Merged
merged 6 commits into from Aug 23, 2019
Merged

perdition (imap/pop3 proxy) rule #407

merged 6 commits into from Aug 23, 2019

Conversation

gkissand
Copy link
Contributor

This decoder and rule will monitor perdition connections and create a level 10 alert on multiple connections from same source ip

For maintainers: PCI tags, descriptions etc were copied from pure-ftp decoders/rules. It successfully detected DoS attacks (tested live)

@Zenidd Zenidd added rules Rules related issues community labels Jun 5, 2019
@Zenidd
Copy link
Contributor

Zenidd commented Jun 5, 2019

Hello @gkissand,

Thanks for your contribution. We will review it and if possible, it will be added to Wazuh-Ruleset.



Best regards,

Juan Pablo Sáez

@Lopuiz Lopuiz changed the base branch from master to 3.9 June 10, 2019 08:42
@Lopuiz Lopuiz self-assigned this Jun 10, 2019
@Lopuiz Lopuiz self-requested a review June 10, 2019 08:59
Copy link
Contributor

@Lopuiz Lopuiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @gkissand,

First, thanks for your contribution to the Ruleset project.
Rules and decoders work fine.
We will merge it as soon as possible.

Regards, Eva

@Lopuiz Lopuiz requested a review from bah07 June 21, 2019 10:54
@Lopuiz Lopuiz changed the base branch from 3.9 to 3.10 August 6, 2019 09:31
@Lopuiz Lopuiz added this to In progress in Wazuh 3.10.0 via automation Aug 13, 2019
@Lopuiz Lopuiz moved this from In progress to Reviewer approved in Wazuh 3.10.0 Aug 13, 2019
@chemamartinez chemamartinez self-requested a review August 22, 2019 09:01
- Author: George Kissandrakis <gkissand@gmail.com>
-->
<group name="syslog,perdition">
<rule id="100100" level="0">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, rule IDs greater than 100000 are reserved for custom rules. Please change these IDs to others less than 100000.

Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Should I do the rule id changes?
If so, is there an inventory of rule ids not to use an id that is already in use?

Thank you
George

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gkissand,

First of all, thanks for your contribution to the project.

I think the best solution here is to add this group of rules to the syslog dedicated file: https://github.com/wazuh/wazuh-ruleset/blob/3.10/rules/0020-syslog_rules.xml

That way we are not creating a new file for three rules related to syslog. You can continue the rule IDs account for that file. I would use IDs 2961-2963.

Regards.

Wazuh 3.10.0 automation moved this from Review approved to Review in progress Aug 22, 2019
@chemamartinez chemamartinez removed this from Review in progress in Wazuh 3.10.0 Aug 22, 2019
@chemamartinez chemamartinez added this to In progress in Wazuh 3.11.0 via automation Aug 22, 2019
@gkissand
Copy link
Contributor Author

I added perdition rules in the syslog file as recommended
Thank you for your help

@chemamartinez
Copy link
Contributor

I added perdition rules in the syslog file as recommended
Thank you for your help

Hi @gkissand,

I cannot see any change in the Syslog rules file. Have you pushed your last changes?

Regards.

@chemamartinez chemamartinez removed this from In progress in Wazuh 3.11.0 Aug 23, 2019
@chemamartinez chemamartinez added this to In progress in Wazuh 3.10.0 via automation Aug 23, 2019
@gkissand
Copy link
Contributor Author

As you might have realized I am not very familiar with github/git. I think I managed this time. If it's not problem, feel free to do any changes needed for merging to master

thank you

@chemamartinez
Copy link
Contributor

As you might have realized I am not very familiar with github/git. I think I managed this time. If it's not problem, feel free to do any changes needed for merging to master

thank you

Now I see the rules duplicated, don't worry about it, I'll fix it while merging. Thanks again for the contribution and for applying the requested changes. It will be available in the next minor version (3.10.0).

Regards.

@chemamartinez chemamartinez merged commit 1b56215 into wazuh:3.10 Aug 23, 2019
Wazuh 3.10.0 automation moved this from In progress to Done Aug 23, 2019
@Lopuiz Lopuiz mentioned this pull request Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community rules Rules related issues
Projects
No open projects
Wazuh 3.10.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants