Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete deprecated python 2 #1052

Merged
merged 5 commits into from Apr 8, 2021

Conversation

asteriscos
Copy link
Member

Hi team,

this deletes python 2 retrocompatibility.

Closes #947

@asteriscos asteriscos requested a review from a team April 8, 2021 17:13
@asteriscos asteriscos self-assigned this Apr 8, 2021
@eze9252 eze9252 self-assigned this Apr 8, 2021
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Machi3mfl Machi3mfl requested a review from eze9252 April 8, 2021 18:28
@eze9252 eze9252 removed their assignment Apr 8, 2021
Copy link
Contributor

@eze9252 eze9252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@gabiwassan gabiwassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
(just some unused lines to remove)

@@ -7,23 +7,13 @@

PY3K = sys.version_info >= (3, 0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PY3K is not used?

Comment on lines 25 to 26
#: Python 3.x?
is_py3 = (_ver[0] == 3)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same these is_py3 is_py2 _ver

@Machi3mfl Machi3mfl merged commit 42e71cf into 4.2-8.1 Apr 8, 2021
@AlexRuiz7 AlexRuiz7 deleted the enhance/delete-deprecated-python2-code-947 branch February 2, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants