Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated deprecated authd options #1172

Merged
merged 6 commits into from Jan 19, 2022
Merged

Conversation

Machi3mfl
Copy link
Member

Hi Team,
This PR updated the deprecated authd options in Managment > Configuration > Registration service
Closes #1110

@Machi3mfl Machi3mfl requested a review from a team November 9, 2021 12:06
Copy link
Member

@AlexRuiz7 AlexRuiz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole registration-service.html template could be formatted to improve code maintenance and readability, so for example

<wz-config-item label="Verify agents using a CA certificate" value="currentConfig['auth-auth'].auth.ssl_verify_host"></wz-config-item>

could be changed to

<wz-config-item 
  label="Verify agents using a CA certificate" 
  value="currentConfig['auth-auth'].auth.ssl_verify_host">
</wz-config-item>

this last chunk of code is much easier to read

@sortiz1191 sortiz1191 self-requested a review November 18, 2021 11:51
@eze9252 eze9252 changed the base branch from 4.2-8.1 to 4.3-8.2 November 30, 2021 15:27
@asteriscos asteriscos merged commit 63acd4e into 4.3-8.2 Jan 19, 2022
@AlexRuiz7 AlexRuiz7 deleted the feat/1110-update-authd-options branch January 28, 2022 16:46
@AlexRuiz7 AlexRuiz7 added this to To do in Release 4.3.0 Jan 28, 2022
@AlexRuiz7 AlexRuiz7 moved this from To do to Done in Release 4.3.0 Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Update references to deprecated authd options and consider the new ones.
3 participants