Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR] Add agent synchronization statistics #1355

Merged
merged 13 commits into from Sep 7, 2022
Merged

[PR] Add agent synchronization statistics #1355

merged 13 commits into from Sep 7, 2022

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Jul 12, 2022 •
edited by AlexRuiz7

Description:

Added agent synchronization status in the agent view.
And the endpoint response type has been modified GET /agents/summary/status so the responses of the views using that endpoint have been fixed.

Issue:

Test:

  1. Navigate to the following views:
    - Overview
    - Management/Status
    - Agents
  2. The number of agents in the different states should be displayed.
  3. in the agent module in the details part there should appear Agents synced and in the table, there should be a Synchronized column.

Screenshot:

Overview:

image

Management/Status:

image

Agents:

image

@yenienserrano yenienserrano linked an issue Jul 12, 2022 that may be closed by this pull request
Add agent synchronization statistics #1309
Closed
11 tasks
@yenienserrano yenienserrano mentioned this pull request Jul 12, 2022
Closed
11 tasks
asteriscos
asteriscos approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Use constants for variables that are not reassigned.
Test: ✔️

image

SplunkAppForWazuh/appserver/static/js/controllers/agents/agents/agentsCtrl.js Outdated Show resolved Hide resolved
@chantal-kelm chantal-kelm self-requested a review July 14, 2022 11:35
chantal-kelm
chantal-kelm approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

Screenshot from 2022-07-14 11-23-36
Screenshot from 2022-07-14 11-23-53
Screenshot from 2022-07-14 11-24-06

@AlexRuiz7 AlexRuiz7 marked this pull request as draft July 18, 2022 11:52
@AlexRuiz7 AlexRuiz7 changed the title Update get /agents/summary/status response [PR] Add agent synchronization statistics Jul 18, 2022
AlexRuiz7
AlexRuiz7 reviewed Jul 20, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
AlexRuiz7
AlexRuiz7 reviewed Jul 20, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@yenienserrano yenienserrano marked this pull request as ready for review July 28, 2022 10:42
asteriscos
asteriscos approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

Screenshot from 2022-09-06 19-25-01

Screenshot from 2022-09-06 19-24-43

Screenshot from 2022-09-06 19-24-33

@AlexRuiz7 AlexRuiz7 changed the base branch from 4.4 to master September 7, 2022 09:17
@AlexRuiz7 AlexRuiz7 changed the base branch from master to 4.4 September 7, 2022 09:18
AlexRuiz7
AlexRuiz7 approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@AlexRuiz7 AlexRuiz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code review: ✔️
  • Test: ✔️

@AlexRuiz7 AlexRuiz7 merged commit 0a2a5d6 into 4.4 Sep 7, 2022
@AlexRuiz7 AlexRuiz7 deleted the Update-GET-/agents/summary/status-response branch September 7, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

@AlexRuiz7 AlexRuiz7 AlexRuiz7 approved these changes

@chantal-kelm chantal-kelm Awaiting requested review from chantal-kelm

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add agent synchronization statistics
4 participants
@yenienserrano @asteriscos @AlexRuiz7 @chantal-kelm