New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add information about eventlog in API report #10602
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliancnn
force-pushed
the
6565-report-windows-localfile
branch
2 times, most recently
from
October 20, 2021 19:41
726a80b
to
117ac73
Compare
nmkoremblum
force-pushed
the
6565-report-windows-localfile
branch
from
October 21, 2021 19:29
f80fc84
to
84b3fc3
Compare
nmkoremblum
previously approved these changes
Oct 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checked again the feature, with the last fixes, and obtained the following outputs:
Windows Server 2016
{
"localfile": [
{
"channel": "Application",
"logformat": "eventchannel",
"ignore_binaries": "no",
"only-future-events": "yes",
"target": [
"agent"
],
"reconnect_time": 5
},
{
"channel": "Security",
"logformat": "eventchannel",
"query": "Event/System[EventID != 5145 and EventID != 5156 and EventID != 5447 and\n EventID != 4656 and EventID != 4658 and EventID != 4663 and EventID != 4660 and\n EventID != 4670 and EventID != 4690 and EventID != 4703 and EventID != 4907 and\n EventID != 5152 and EventID != 5157]",
"ignore_binaries": "no",
"only-future-events": "yes",
"target": [
"agent"
],
"reconnect_time": 5
},
{
"channel": "System",
"logformat": "eventchannel",
"ignore_binaries": "no",
"only-future-events": "yes",
"target": [
"agent"
],
"reconnect_time": 5
},
{
"file": "active-response\\active-responses.log",
"logformat": "syslog",
"ignore_binaries": "no",
"only-future-events": "yes",
"target": [
"agent"
]
}
]
}
Windows XP
{
"localfile": [
{
"channel": "Application",
"logformat": "eventlog",
"ignore_binaries": "no",
"target": [
"agent"
]
},
{
"channel": "Security",
"logformat": "eventlog",
"ignore_binaries": "no",
"target": [
"agent"
]
},
{
"channel": "System",
"logformat": "eventlog",
"ignore_binaries": "no",
"target": [
"agent"
]
},
{
"file": "active-response\\active-responses.log",
"logformat": "syslog",
"ignore_binaries": "no",
"only-future-events": "yes",
"target": [
"agent"
]
}
]
}
LGTM :)
juliancnn
previously approved these changes
Oct 26, 2021
W10 - default config:Response: ok {
"localfile": [
{
"channel": "Application",
"logformat": "eventchannel",
"ignore_binaries": "no",
"only-future-events": "yes",
"target": [
"agent"
],
"reconnect_time": 5
},
{
"channel": "Security",
"logformat": "eventchannel",
"query": "Event/System[EventID != 5145 and EventID != 5156 and EventID != 5447 and\n EventID != 4656 and EventID != 4658 and EventID != 4663 and EventID != 4660 and\n EventID != 4670 and EventID != 4690 and EventID != 4703 and EventID != 4907 and\n EventID != 5152 and EventID != 5157]",
"ignore_binaries": "no",
"only-future-events": "yes",
"target": [
"agent"
],
"reconnect_time": 5
},
{
"channel": "System",
"logformat": "eventchannel",
"ignore_binaries": "no",
"only-future-events": "yes",
"target": [
"agent"
],
"reconnect_time": 5
},
{
"file": "active-response\\active-responses.log",
"logformat": "syslog",
"ignore_binaries": "no",
"only-future-events": "yes",
"target": [
"agent"
]
}
]
} |
Windows Server{
"localfile": [
{
"channel": "Application",
"logformat": "eventchannel",
"ignore_binaries": "no",
"only-future-events": "yes",
"target": [
"agent"
],
"reconnect_time": 5
},
{
"channel": "Security",
"logformat": "eventchannel",
"query": "Event/System[EventID != 5145 and EventID != 5156 and EventID != 5447 and\n EventID != 4656 and EventID != 4658 and EventID != 4663 and EventID != 4660 and\n EventID != 4670 and EventID != 4690 and EventID != 4703 and EventID != 4907 and\n EventID != 5152 and EventID != 5157]",
"ignore_binaries": "no",
"only-future-events": "yes",
"target": [
"agent"
],
"reconnect_time": 5
},
{
"channel": "System",
"logformat": "eventchannel",
"ignore_binaries": "no",
"only-future-events": "yes",
"target": [
"agent"
],
"reconnect_time": 5
},
{
"file": "active-response\\active-responses.log",
"logformat": "syslog",
"ignore_binaries": "no",
"only-future-events": "yes",
"target": [
"agent"
]
}
]
} LGTM ! |
miguemedina11
previously approved these changes
Oct 27, 2021
juliancnn
dismissed stale reviews from miguemedina11, nmkoremblum, and themself
via
November 1, 2021 14:49
f491ad1
juliancnn
force-pushed
the
6565-report-windows-localfile
branch
from
November 1, 2021 14:49
84b3fc3
to
f491ad1
Compare
LGTM ! |
juliancnn
approved these changes
Nov 2, 2021
nmkoremblum
approved these changes
Nov 2, 2021
vikman90
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add the
location
parameter of thelocalfile
(channel) to theAPI
responses, when querying theLogcollector's localfiles
configuration. These changes only affect thelocalfiles
that haveeventchannel
oreventlog
formats.Eventlog
Given the following configuration:
Then, querying the logcollector API' socket, the following response is obtained:
Eventchannel
Given the following configuration:
Then, querying the logcollector API' socket, the following response is obtained:
Tests
MAC OS XSource installationSource upgradeReview logs syntax and correct languageQA templates contemplate the added capabilitiesCoverityValgrind (memcheck and descriptor leaks check)Dr. MemoryAddressSanitizerCoverityDr. MemoryScan-build reportLeaksAddressSanitizerWorking on cluster environmentsThe data flow works as expected (agent-manager-api-app)Stress test for affected components