New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework of PR #9238 - OracleDB 12c Integration #11274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no test file for new rules.
There are no example logs, only alerts already processed by Wazuh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Description
This PR aims to resolve issues detected under #9238 PR. Closes #11272.
The issues resolved are:
Notes:
Checks and changes
Syntax
Grammar
Semantic
Unit testing
All rules and decoders test.
E2E testing
~~ 5.a Logs for new or modified decoder/rules sent to a manager running with this PR ruleset appear in Kibana.~~
5.b There are no affected or broken visualizations on Kibana.
5.c New or modified items can be seen correctly using APP ruleset navigation.
Elasticsearch Template
Stoppers
Others