Remove unused subprocess imports in core/utils.py and core/common.py
#12101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcarmona99
force-pushed
the
dev-fix-python-code-vulnerabilities
branch
from
50df6c8
to
34905eb
Compare
* Fix possible XML flaws * Add requested changes
mcarmona99
force-pushed
the
feature/remove-unused-subprocess-imports
branch
from
79099bd
to
b446975
Compare
16 tasks
davidjiglesias
approved these changes
Feb 7, 2022
davidjiglesias
pushed a commit
that referenced
this pull request
Feb 11, 2022
* Handle more exceptions in the wodles and remove duplicated functions from framework file (#10478) * Remove unused functions from framework common.py * Minor fixes #10155 * Add requested changes #10155 * Fix random values at cluster zip filename to be cryptographically secure (#10710) * Changed permission mask (#10636) * Remove execute method from core/utils.py since it is not being used (#10740) * Fix tempfiles handling at `framework/wazuh/core/configuration.py` and `framework/wazuh/core/utils.py` (#10544) * Fix tempfiles handling at configuration.py and utils.py * Add requested changes * Fixed flaws in XML calls at framework files (#10635) * Fix possible XML flaws * Add requested changes * Fix a possible flaw regarding `try`, `except` and `pass` code block (#11951) * Fix a possible flaw regarding try, except and pass code block * Add requested changes * Remove unused `subprocess` imports in `core/utils.py` and `core/common.py` (#12101) * Remove execute method from core/utils.py since it is not being used (#10740) * Fixed flaws in XML calls at framework files (#10635) * Fix possible XML flaws * Add requested changes * Remove unused imports caused by rebase conflicts Co-authored-by: Alexis Rivas <84642680+Kondent@users.noreply.github.com> * Fix a rebase conflict related with #10782 and #10710 Co-authored-by: Gonzalo Abril Paniza <gonzalo.abril@wazuh.com> Co-authored-by: Manuel Carmona Pérez <manuel.carmona@wazuh.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is part of #10125.
As it was said in wazuh/wazuh-qa#2330 (comment), one of the required fixes has to do with a rebase conflict in some of the pull requests related to this epic.
In this case, this pull request removes the
from subprocess import CalledProcessError, check_outputline fromframework/wazuh/core/utils.pysince it's not being used and it's reported as a new framework flaw. It also removesimport subprocess from framework/wazuh/core/common.pysince it's not being used and it's known as a false positive.