New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review and update Gcloud unit tests #13573
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mcarmona99
reviewed
May 27, 2022
mcarmona99
suggested changes
May 30, 2022
CarlosRS9
force-pushed
the
feature/13389-gcloud-unit-tests
branch
2 times, most recently
from
June 1, 2022 12:02
a7c8133
to
b40dcc2
Compare
CarlosRS9
force-pushed
the
feature/13389-gcloud-unit-tests
branch
from
June 9, 2022 09:36
b40dcc2
to
bed784b
Compare
CarlosRS9
force-pushed
the
feature/13389-gcloud-unit-tests
branch
from
June 20, 2022 09:12
bed784b
to
6e1aca7
Compare
mcarmona99
approved these changes
Jun 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
davidjiglesias
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #13389 we have reviewed, updated, replaced existing unit tests for our gcloud module while adding new ones to expand code coverage up to 99%. This is the actual coverage using the new unit tests:
To achieve this it was necessary to replace existing unit tests and create them from start. However, it has not been possible to create a
tools.py
auxiliary module for the unit tests due to the problem of the wodle folder not being an installable python package. Once #12874 is addressed, it will be possible to do so, further optimising the design of these unit tests.The extensive code review has resulted in several optimizations, changes and removal of some parts of the code. Because of that, manual testing was necessary to ensure everything still works as expected.