New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standarize time install date #14161

Merged

Dwordcito merged 9 commits into 4.5 from dev-13884-standarize-time-installDate

Jun 13, 2023

Member

MiguelazoDS commented Jul 6, 2022 •

edited

Related issue
#13884

Description

This PR converts the timestamp where a package was installed (install_time in sys_programs) into a "%Y/%m/%d %H:%M:%S" format value.

Dod

Expand

Scan-build

UTs

Update 03/03/23

Smoke test after rebase

Expand

Scan-build

UTs

Current state of 4.5 branch

This implementation

Tests

Compilation without warnings in every supported platform
- Windows
Review logs syntax and correct language

Memory tests for Windows
- Scan-build report

Added unit tests (for new features)

MiguelazoDS force-pushed the dev-13884-standarize-time-installDate branch from 72f3687 to 3ef0521 Compare

July 7, 2022 19:43

MiguelazoDS self-assigned this

MiguelazoDS linked an issue

that may be closed by this pull request

Standardize time zone in InstallDate field in Windows package information #13884

Closed

Member Author

MiguelazoDS commented Jul 7, 2022 •

edited

DoD

`install_time` before

`install_time` after

Findings

The timestamp for Windows App Store suddenly return a " " string as well as other applications that started to appear after changing the language.

MiguelazoDS marked this pull request as ready for review

July 7, 2022 20:44

MiguelazoDS force-pushed the dev-13884-standarize-time-installDate branch 3 times, most recently from cf5c02f to 97f3957 Compare

July 8, 2022 00:08

HanesSciarrone suggested changes

View reviewed changes

src/shared_modules/utils/timeHelper.h Outdated Show resolved Hide resolved

src/shared_modules/utils/windowsHelper.h Outdated Show resolved Hide resolved

src/shared_modules/utils/windowsHelper.h Outdated Show resolved Hide resolved

src/shared_modules/utils/windowsHelper.h Outdated Show resolved Hide resolved

src/shared_modules/utils/windowsHelper.h Outdated Show resolved Hide resolved

src/shared_modules/utils/windowsHelper.h Outdated Show resolved Hide resolved

src/shared_modules/utils/windowsHelper.h Outdated Show resolved Hide resolved

HanesSciarrone suggested changes

View reviewed changes

src/shared_modules/utils/windowsHelper.h Outdated Show resolved Hide resolved

src/shared_modules/utils/windowsHelper.h Outdated Show resolved Hide resolved

MiguelazoDS force-pushed the dev-13884-standarize-time-installDate branch from cda1765 to 90ff614 Compare

July 8, 2022 21:42

pereyra-m reviewed

View reviewed changes

Member

pereyra-m left a comment

Please check:

The upgrade scenario, in case we have legacy packages with the old format

src/shared_modules/utils/tests/windowsHelper_test.cpp Outdated Show resolved Hide resolved

src/shared_modules/utils/windowsHelper.h Outdated Show resolved Hide resolved

src/shared_modules/utils/windowsHelper.h Outdated Show resolved Hide resolved

src/shared_modules/utils/windowsHelper.h Outdated Show resolved Hide resolved

Dwordcito requested review from Dwordcito and Damian-Mangold

July 11, 2022 15:37

MiguelazoDS force-pushed the dev-13884-standarize-time-installDate branch 2 times, most recently from 46871bc to f39727f Compare

July 11, 2022 19:15

Damian-Mangold previously approved these changes

View reviewed changes

HanesSciarrone suggested changes

View reviewed changes

src/shared_modules/utils/stringHelper.h Outdated Show resolved Hide resolved

src/shared_modules/utils/timeHelper.h Outdated Show resolved Hide resolved

src/shared_modules/utils/windowsHelper.h Outdated Show resolved Hide resolved

MiguelazoDS dismissed Damian-Mangold’s stale review via

becf5f9

August 5, 2022 00:05

MiguelazoDS force-pushed the dev-13884-standarize-time-installDate branch from f39727f to becf5f9 Compare

August 5, 2022 00:05

Member Author

MiguelazoDS commented Aug 5, 2022

Update 04/08/22 after rebase

Tests

MiguelazoDS force-pushed the dev-13884-standarize-time-installDate branch 2 times, most recently from 0c1a197 to 2a687af Compare

August 5, 2022 18:06

MiguelazoDS mentioned this pull request

QA testing - Standardize time zone in InstallDate field in Windows package information wazuh/wazuh-qa#3158

Closed

4 tasks

MiguelazoDS force-pushed the dev-13884-standarize-time-installDate branch from 2a687af to 08c74b7 Compare

August 25, 2022 15:38

Dwordcito requested changes

View reviewed changes

src/shared_modules/utils/stringHelper.h Outdated Show resolved Hide resolved

src/shared_modules/utils/windowsHelper.h Outdated Show resolved Hide resolved

pereyra-m previously approved these changes

View reviewed changes

MiguelazoDS dismissed pereyra-m’s stale review via

b8147cd

September 6, 2022 21:09

Dwordcito previously approved these changes

View reviewed changes

pereyra-m previously approved these changes

View reviewed changes

Member

pereyra-m left a comment

LGTM!

pereyra-m force-pushed the dev-13884-standarize-time-installDate branch 2 times, most recently from 76cb448 to 7fb752c Compare

May 9, 2023 13:56

vikman90 removed the team/core/data pirates label

Dwordcito requested review from Dwordcito and Damian-Mangold and removed request for Damian-Mangold

June 1, 2023 13:27


          Normalize timestamp install_date

c52e8df

MiguelazoDS force-pushed the dev-13884-standarize-time-installDate branch from 7fb752c to 136828b Compare

June 2, 2023 15:09

Dwordcito requested changes

View reviewed changes

src/shared_modules/utils/windowsHelper.h Outdated Show resolved Hide resolved

src/shared_modules/utils/windowsHelper.h Outdated Show resolved Hide resolved

src/shared_modules/utils/windowsHelper.h Outdated Show resolved Hide resolved

src/shared_modules/utils/windowsHelper.h Outdated Show resolved Hide resolved

src/shared_modules/utils/windowsHelper.h Outdated Show resolved Hide resolved

src/shared_modules/utils/windowsHelper.h Outdated Show resolved Hide resolved

MiguelazoDS dismissed pereyra-m’s stale review via

43fc34f

June 7, 2023 18:03

pereyra-m previously approved these changes

View reviewed changes

MiguelazoDS dismissed pereyra-m’s stale review via

449c9bf

June 12, 2023 18:46

Dwordcito requested review from pereyra-m and Dwordcito

June 13, 2023 15:46

Dwordcito approved these changes

View reviewed changes

pereyra-m approved these changes

View reviewed changes

MiguelazoDS and others added 8 commits

June 13, 2023 14:24


          Added UTs for the timestamp normalization

dd791a6


          Add helper to check if one string contains a number

9577d92


          Add helper unit test for non happy cases

613f6ee


          Change isNumber implementation for better performance

b475e20


          Fix warnings missing initializer for members

fd14d73


          Naming convention change

618c9a7


          Add exception management for installTime

4c23b8c


          Fix tests after new approach of exception management

cdfecec

Dwordcito force-pushed the dev-13884-standarize-time-installDate branch from 449c9bf to cdfecec Compare

June 13, 2023 17:25

Dwordcito merged commit 1f5418d into 4.5

74 checks passed

Dwordcito deleted the dev-13884-standarize-time-installDate branch

June 13, 2023 19:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment