Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python test requirements.txt #16513

Merged
merged 7 commits into from May 30, 2023
Merged

Add python test requirements.txt #16513

merged 7 commits into from May 30, 2023

Conversation

GGP1
Copy link
Member

@GGP1 GGP1 commented Mar 27, 2023 •
edited

Related issue
Closes #16377

Description

Adds a new requirements-dev.txt file to be used for development purposes. It contains all framework module's dependencies (existing requirements.txt) as well as tools and dependencies used to run unit and integration tests.

Tests

Framework unit tests

Logs 
(venv) gasti@pop-os:~/work/wazuh$ python3 -m pytest framework --disable-warnings
======================================================= test session starts ========================================================
platform linux -- Python 3.9.16, pytest-5.4.3, pluggy-1.0.0
rootdir: /home/gasti/work/wazuh/framework
plugins: aiohttp-0.3.0, anyio-3.6.2, tavern-1.2.2, trio-0.7.0, html-2.1.1, asyncio-0.15.1, metadata-2.0.4
collected 2092 items                                                                                                               

framework/scripts/tests/test_agent_groups.py ..............                                                                  [  0%]
framework/scripts/tests/test_agent_upgrade.py ..............                                                                 [  1%]
framework/scripts/tests/test_cluster_control.py ......                                                                       [  1%]
framework/scripts/tests/test_rbac_control.py .........                                                                       [  2%]
framework/scripts/tests/test_wazuh_clusterd.py .......                                                                       [  2%]
framework/scripts/tests/test_wazuh_logtest.py ......................                                                         [  3%]
framework/wazuh/core/cluster/dapi/tests/test_dapi.py ................................                                        [  4%]
framework/wazuh/core/cluster/tests/test_client.py ................                                                           [  5%]
framework/wazuh/core/cluster/tests/test_cluster.py ...................................                                       [  7%]
framework/wazuh/core/cluster/tests/test_common.py .......................................................................... [ 10%]
........                                                                                                                     [ 11%]
framework/wazuh/core/cluster/tests/test_control.py ......                                                                    [ 11%]
framework/wazuh/core/cluster/tests/test_local_client.py ..............                                                       [ 12%]
framework/wazuh/core/cluster/tests/test_local_server.py ........................                                             [ 13%]
framework/wazuh/core/cluster/tests/test_master.py ...............................................                            [ 15%]
framework/wazuh/core/cluster/tests/test_server.py .............................                                              [ 17%]
framework/wazuh/core/cluster/tests/test_utils.py ...........                                                                 [ 17%]
framework/wazuh/core/cluster/tests/test_worker.py ..................................                                         [ 19%]
framework/wazuh/core/tests/test_active_response.py ..............                                                            [ 19%]
framework/wazuh/core/tests/test_agent.py ................................................................................... [ 23%]
................................................................                                                             [ 26%]
framework/wazuh/core/tests/test_cdb_list.py ......................................                                           [ 28%]
framework/wazuh/core/tests/test_common.py .........                                                                          [ 29%]
framework/wazuh/core/tests/test_configuration.py .......................................................................     [ 32%]
framework/wazuh/core/tests/test_database.py .............                                                                    [ 33%]
framework/wazuh/core/tests/test_decoder.py ................                                                                  [ 33%]
framework/wazuh/core/tests/test_exception.py ...                                                                             [ 34%]
framework/wazuh/core/tests/test_input_validator.py ...                                                                       [ 34%]
framework/wazuh/core/tests/test_logtest.py ..                                                                                [ 34%]
framework/wazuh/core/tests/test_manager.py ................                                                                  [ 35%]
framework/wazuh/core/tests/test_mitre.py .............                                                                       [ 35%]
framework/wazuh/core/tests/test_pyDaemonModule.py .....                                                                      [ 35%]
framework/wazuh/core/tests/test_results.py ........................................                                          [ 37%]
framework/wazuh/core/tests/test_rootcheck.py .............                                                                   [ 38%]
framework/wazuh/core/tests/test_rule.py ......................                                                               [ 39%]
framework/wazuh/core/tests/test_sca.py ........................                                                              [ 40%]
framework/wazuh/core/tests/test_security.py .............                                                                    [ 41%]
framework/wazuh/core/tests/test_stats.py .................                                                                   [ 42%]
framework/wazuh/core/tests/test_syscheck.py .......                                                                          [ 42%]
framework/wazuh/core/tests/test_syscollector.py ...                                                                          [ 42%]
framework/wazuh/core/tests/test_task.py ........                                                                             [ 42%]
framework/wazuh/core/tests/test_utils.py ................................................................................... [ 46%]
............................................................................................................................ [ 52%]
...................................                                                                                          [ 54%]
framework/wazuh/core/tests/test_vulnerability.py ..                                                                          [ 54%]
framework/wazuh/core/tests/test_wazuh_queue.py ....................                                                          [ 55%]
framework/wazuh/core/tests/test_wazuh_socket.py ....................                                                         [ 56%]
framework/wazuh/core/tests/test_wdb.py ...............................                                                       [ 58%]
framework/wazuh/core/tests/test_wlogging.py ............                                                                     [ 58%]
framework/wazuh/rbac/tests/test_auth_context.py ..                                                                           [ 58%]
framework/wazuh/rbac/tests/test_decorators.py .............................................................................. [ 62%]
...............................                                                                                              [ 63%]
framework/wazuh/rbac/tests/test_default_configuration.py ........................................................            [ 66%]
framework/wazuh/rbac/tests/test_orm.py .................................................................                     [ 69%]
framework/wazuh/rbac/tests/test_preprocessor.py ...........                                                                  [ 70%]
framework/wazuh/tests/test_active_response.py ............                                                                   [ 70%]
framework/wazuh/tests/test_agent.py ........................................................................................ [ 75%]
.............................                                                                                                [ 76%]
framework/wazuh/tests/test_cdb_list.py .....................................................                                 [ 78%]
framework/wazuh/tests/test_ciscat.py .................................                                                       [ 80%]
framework/wazuh/tests/test_cluster.py ..........                                                                             [ 80%]
framework/wazuh/tests/test_decoder.py ...................................                                                    [ 82%]
framework/wazuh/tests/test_group.py .......                                                                                  [ 82%]
framework/wazuh/tests/test_logtest.py ......                                                                                 [ 83%]
framework/wazuh/tests/test_manager.py ....................................                                                   [ 84%]
framework/wazuh/tests/test_mitre.py .......                                                                                  [ 85%]
framework/wazuh/tests/test_rootcheck.py ..................................................                                   [ 87%]
framework/wazuh/tests/test_rule.py .......................................................                                   [ 90%]
framework/wazuh/tests/test_sca.py ...........                                                                                [ 90%]
framework/wazuh/tests/test_security.py .......................................................................               [ 94%]
framework/wazuh/tests/test_stats.py ...............                                                                          [ 94%]
framework/wazuh/tests/test_syscheck.py .........................                                                             [ 96%]
framework/wazuh/tests/test_syscollector.py ............                                                                      [ 96%]
framework/wazuh/tests/test_task.py ............................                                                              [ 98%]
framework/wazuh/tests/test_vulnerability.py ........................................                                         [100%]

========================================== 2092 passed, 56 warnings in 211.94s (0:03:31) ===========================================

API unit tests

Logs 
(venv) gasti@pop-os:~/work/wazuh$ python3 -m pytest api/api -x --disable-warnings
=================================================== test session starts ====================================================
platform linux -- Python 3.9.16, pytest-5.4.3, pluggy-1.0.0
rootdir: /home/gasti/work/wazuh/api
plugins: anyio-3.6.2, asyncio-0.18.1
asyncio: mode=legacy
collected 544 items                                                                                                        

api/api/controllers/test/test_active_response_controller.py .                                                        [  0%]
api/api/controllers/test/test_agent_controller.py ...........................................                        [  8%]
api/api/controllers/test/test_cdb_list_controller.py ......                                                          [  9%]
api/api/controllers/test/test_ciscat_controller.py .                                                                 [  9%]
api/api/controllers/test/test_cluster_controller.py ........................                                         [ 13%]
api/api/controllers/test/test_decoder_controller.py .......                                                          [ 15%]
api/api/controllers/test/test_default_controller.py .                                                                [ 15%]
api/api/controllers/test/test_experimental_controller.py ...............                                             [ 18%]
api/api/controllers/test/test_manager_controller.py ..................                                               [ 21%]
api/api/controllers/test/test_mitre_controller.py .......                                                            [ 22%]
api/api/controllers/test/test_overview_controller.py .                                                               [ 22%]
api/api/controllers/test/test_rootcheck_controller.py ....                                                           [ 23%]
api/api/controllers/test/test_rule_controller.py ........                                                            [ 25%]
api/api/controllers/test/test_sca_controller.py ..                                                                   [ 25%]
api/api/controllers/test/test_security_controller.py ...................................................             [ 34%]
api/api/controllers/test/test_syscheck_controller.py ....                                                            [ 35%]
api/api/controllers/test/test_syscollector_controller.py .........                                                   [ 37%]
api/api/controllers/test/test_task_controller.py .                                                                   [ 37%]
api/api/controllers/test/test_vulnerability_controller.py ....                                                       [ 38%]
api/api/models/test/test_model.py ...........................                                                        [ 43%]
api/api/test/test_alogging.py ..................                                                                     [ 46%]
api/api/test/test_authentication.py ...........                                                                      [ 48%]
api/api/test/test_configuration.py ............................................                                      [ 56%]
api/api/test/test_encoder.py ...                                                                                     [ 56%]
api/api/test/test_middlewares.py ............                                                                        [ 59%]
api/api/test/test_uri_parser.py ...                                                                                  [ 59%]
api/api/test/test_util.py ..............................................                                             [ 68%]
api/api/test/test_validator.py ..................................................................................... [ 83%]
........................................................................................                             [100%]

============================================= 544 passed, 34 warnings in 2.16s =============================================

Wodles unit tests

Logs 
(venv) gasti@pop-os:~/work/wazuh$ python3 -m pytest wodles --disable-warnings
======================================================= test session starts ========================================================
platform linux -- Python 3.9.16, pytest-5.4.3, pluggy-1.0.0
rootdir: /home/gasti/work/wazuh
plugins: aiohttp-0.3.0, anyio-3.6.2, tavern-1.2.2, trio-0.7.0, html-2.1.1, asyncio-0.15.1, metadata-2.0.4
collected 269 items                                                                                                                

wodles/aws/tests/test_aws.py .......................................                                                         [ 14%]
wodles/azure/tests/test_azure.py ........................................................................................... [ 48%]
.........................                                                                                                    [ 57%]
wodles/azure/tests/test_orm.py .......................                                                                       [ 66%]
wodles/docker-listener/tests/test_docker_listener.py ...................                                                     [ 73%]
wodles/gcloud/tests/test_bucket.py .................................                                                         [ 85%]
wodles/gcloud/tests/test_gcloud.py .........                                                                                 [ 88%]
wodles/gcloud/tests/test_integration.py ........                                                                             [ 91%]
wodles/gcloud/tests/test_subscriber.py ..............                                                                        [ 97%]
wodles/gcloud/tests/test_tools.py ........                                                                                   [100%]

================================================== 269 passed, 1 warning in 1.61s ==================================================

API integration tests

Logs

It's just a subset of the logs to avoid bloating the PR with text

(venv) gasti@pop-os:~/work/wazuh/api/test/integration$ pytest -vv test_agent_GET_endpoints.tavern.yaml
========================================================================== test session starts ==========================================================================
platform linux -- Python 3.9.16, pytest-5.4.3, py-1.11.0, pluggy-0.13.1 -- /home/gasti/work/wazuh/venv/bin/python
cachedir: .pytest_cache
metadata: {'Python': '3.9.16', 'Platform': 'Linux-6.2.0-76060200-generic-x86_64-with-glibc2.35', 'Packages': {'pytest': '5.0.0', 'pluggy': '0.13.1'}, 'Plugins': {'aiohttp': '0.3.0', 'anyio': '3.6.2', 'tavern': '1.2.2', 'trio': '0.7.0', 'html': '2.1.1', 'asyncio': '0.15.1', 'metadata': '2.0.4'}}
rootdir: /home/gasti/work/wazuh/api/test/integration, inifile: pytest.ini
plugins: aiohttp-0.3.0, anyio-3.6.2, tavern-1.2.2, trio-0.7.0, html-2.1.1, asyncio-0.15.1, metadata-2.0.4
collected 93 items                                                                                                                                                      

test_agent_GET_endpoints.tavern.yaml::GET /agents PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents with single agent id PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/{agent_id}/config/{component}/{configuration} PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/{agent_id}/config/{component}/{configuration} (only cluster configuration) PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/{agent_id}/group/is_sync PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/{agent_id}/key PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/{agent_id}/daemons/stats PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/{agent_id}/stats/{component} PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups filter hash[md5] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups filter hash[sha1] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups filter hash[sha224] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups filter hash[sha256] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups filter hash[sha384] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups filter hash[sha512] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups filter hash[blake2b] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups filter hash[blake2s] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups filter hash[sha3_224] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups filter hash[sha3_256] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups filter hash[sha3_384] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups filter hash[sha3_512] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/agents PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/agents {sort,select}[configSum] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/agents {sort,select}[dateAdd] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/agents {sort,select}[group] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/agents {sort,select}[id] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/agents {sort,select}[ip] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/agents {sort,select}[lastKeepAlive] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/agents {sort,select}[manager] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/agents {sort,select}[mergedSum] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/agents {sort,select}[name] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/agents {sort,select}[node_name] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/agents {sort,select}[os.arch] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/agents {sort,select}[os.build] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/agents {sort,select}[os.codename] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/agents {sort,select}[os.major] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/agents {sort,select}[os.minor] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/agents {sort,select}[os.name] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/agents {sort,select}[os.platform] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/agents {sort,select}[os.uname] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/agents {sort,select}[os.version] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/agents {sort,select}[registerIP] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/agents {sort,select}[status] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/agents {sort,select}[version] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/configuration PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/files PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/files filter hash[md5] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/files filter hash[sha1] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/files filter hash[sha224] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/files filter hash[sha256] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/files filter hash[sha384] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/files filter hash[sha512] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/files filter hash[blake2b] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/files filter hash[blake2s] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/files filter hash[sha3_224] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/files filter hash[sha3_256] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/files filter hash[sha3_384] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/files filter hash[sha3_512] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/files/{filename}/json PASSED
test_agent_GET_endpoints.tavern.yaml::GET /groups/{group_id}/files/{filename}/xml PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents?name=agent_name PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/no_group PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/no_group {sort,select}[dateAdd] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/no_group {sort,select}[id] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/no_group {sort,select}[ip] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/no_group {sort,select}[name] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/no_group {sort,select}[node_name] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/no_group {sort,select}[registerIP] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/no_group {sort,select}[status] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/outdated PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/stats/distinct PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/stats/distinct {fields}[dateAdd] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/stats/distinct {fields}[id] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/stats/distinct {fields}[ip] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/stats/distinct {fields}[lastKeepAlive] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/stats/distinct {fields}[manager] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/stats/distinct {fields}[name] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/stats/distinct {fields}[node_name] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/stats/distinct {fields}[os.arch] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/stats/distinct {fields}[os.build] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/stats/distinct {fields}[os.codename] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/stats/distinct {fields}[os.major] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/stats/distinct {fields}[os.minor] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/stats/distinct {fields}[os.name] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/stats/distinct {fields}[os.platform] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/stats/distinct {fields}[os.uname] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/stats/distinct {fields}[os.version] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/stats/distinct {fields}[registerIP] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/stats/distinct {fields}[status] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/stats/distinct {fields}[version] PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/summary/status PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/summary/os PASSED
test_agent_GET_endpoints.tavern.yaml::GET /agents/upgrade_result PASSED

====================================================================== 93 passed in 204.90 seconds ======================================================================

@GGP1 GGP1 self-assigned this Mar 27, 2023
EduLeon12
EduLeon12 suggested changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@EduLeon12 EduLeon12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Tavern package to avoid errors when launching framework unit test, specifically
pytest -vvs test_active_response_endpoints.tavern.yaml

framework/requirements-dev.txt Outdated Show resolved Hide resolved
@GGP1 GGP1 force-pushed the fix/16377-add-python-dev-requirements branch from 0756e2a to 734f5fe Compare March 30, 2023 13:30
EduLeon12
EduLeon12 previously approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@EduLeon12 EduLeon12 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test both framework and Api test passed.
Some integration tests were tested and they passed as well.

LGTM!!

@mateojames mateojames self-requested a review May 11, 2023 13:06
mateojames
mateojames previously approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@mateojames mateojames left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with some unit test and integration tests and they passed well.

LGTM

@GGP1 GGP1 dismissed stale reviews from mateojames and EduLeon12 via f0da638 May 24, 2023 18:34
@GGP1 GGP1 force-pushed the fix/16377-add-python-dev-requirements branch from 398cb72 to f0da638 Compare May 24, 2023 18:34
EduLeon12
EduLeon12 approved these changes May 29, 2023
View reviewed changes
Copy link
Contributor

@EduLeon12 EduLeon12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After Testing these requirements changes, all passed without issue and behavior was as expected. Therefore I approved this PR.

mateojames
mateojames approved these changes May 29, 2023
View reviewed changes
Copy link
Contributor

@mateojames mateojames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the changes make sense and are justified.

@davidjiglesias davidjiglesias merged commit 27ebaaa into master May 30, 2023
46 checks passed
@davidjiglesias davidjiglesias deleted the fix/16377-add-python-dev-requirements branch May 30, 2023 10:27
GGP1 added a commit that referenced this pull request Jun 27, 2023
@GGP1
Add python test requirements.txt (#16513)
228e447 
* Add file with dev dependencies

* Fix empty value not allowed

* Bump pytest to 7.0.1

* Bump tavern and pykwalify versions

* Use compatible versions

* Revert "Fix empty value not allowed"

This reverts commit 1fb6f11.

* Update versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidjiglesias davidjiglesias davidjiglesias approved these changes

@EduLeon12 EduLeon12 EduLeon12 approved these changes

@mateojames mateojames mateojames approved these changes

Assignees

@GGP1 GGP1

Labels
module/api module/framework type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add python test requirements.txt to repository
4 participants
@GGP1 @davidjiglesias @EduLeon12 @mateojames