New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor default_config method to take into account user config found in .aws/config file #16531
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ab9a935
to
4c9a8fe
Compare
4c9a8fe
to
773782d
Compare
773782d
to
bfda263
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need Integration tests to validate this change.
@EduLeon12, open a new issue to add Unit tests for these changes. The new issue should be blocked by: To do
|
… config file: - Refactored method to take user config file parameters. - Added method to modularize default_config method. - Added new error code. - Added Docstring to method.
Co-authored-by: Nico Stefani <nicolas.stefi@wazuh.com>
Co-authored-by: Nico Stefani <nicolas.stefi@wazuh.com>
- Added new Error Code - Fixed Conditional for dictionaries - Handled error when profile does not exist - Added new debug messages
5d5ba75
to
781a0a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Changes were applied, Integration tests were discarded, unit tests will be added in a new issue once they are merged (still in development).
Description
The default_config was not taken into consideration that the .aws/config file could not have the necessary retries parameters to avoid a throttling error a solution was made to not only look for the retry parameter but also all primary botocore parameters and set them into a botocore Config object.
More information on the solution is described here:
Logs/Alerts example
Now after running the module it will always check for the retries parameters on the config file if the file exists:
Tests
Some scenarios were tested to ensure the module was functioning properly
Ex: