Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set database permissions for dbsync file databases #17447

Merged
merged 2 commits into from Jun 9, 2023

Conversation

Dwordcito
Copy link
Member

Related issue
Closes #17304

Description

This PR aims to set the defined permissions for dbsync databases under the SQLite implementation.

Basically, open the database set file permissions and after this, reopen the file with the new permissions applied.

The component test covers this change.

@Dwordcito Dwordcito self-assigned this Jun 7, 2023
@Dwordcito Dwordcito marked this pull request as draft June 7, 2023 04:05
@Dwordcito Dwordcito force-pushed the 17304-database-permissions-dbsync branch from a3dafd6 to e1b47fe Compare June 7, 2023 12:45
@Dwordcito Dwordcito marked this pull request as ready for review June 7, 2023 12:48
Copy link
Member

@pereyra-m pereyra-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gj!
I haven't too much experience in this section of the code, so the suggestion might not be possible or relevant.

MiguelazoDS
MiguelazoDS previously approved these changes Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants