Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added validation for empty blobs in Azure wodle. #17524

Merged
merged 1 commit into from Jun 20, 2023
Merged

Added validation for empty blobs in Azure wodle. #17524

merged 1 commit into from Jun 20, 2023

Conversation

RamosFe
Copy link
Member

@RamosFe RamosFe commented Jun 12, 2023

Related issue
#17510

Description

Backport Azure InvalidRange error fix from Issue #16866

@RamosFe RamosFe linked an issue Jun 12, 2023 that may be closed by this pull request
Backport Azure InvalidRange error fix #17510
Closed
4 tasks
@GGP1 GGP1 self-requested a review June 13, 2023 12:56
GGP1
GGP1 requested changes Jun 13, 2023
View reviewed changes
Copy link
Member

@GGP1 GGP1 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should backport the modifications to the tests as well: #16805

Also, keep in mind that the checks have to pass in order for the issue to advance to the final review

@RamosFe
Copy link
Member Author

RamosFe commented Jun 13, 2023

We should backport the modifications to the tests as well: #16805

After talking with the team, due to the test being part of another Issue #13390 that is not part of the release 4.4.5 we should not add the tests to this backport.

@GGP1 GGP1 self-requested a review June 16, 2023 12:05
GGP1
GGP1 approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@GGP1 GGP1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering we don't have to migrate tests and that the checks are failing due to the parent branch 4.4.5, I approve these changes.

@RamosFe RamosFe force-pushed the fix/17510-invalid-azure-range branch from 88308fb to 2656b87 Compare June 16, 2023 14:47
@RamosFe
Copy link
Member Author

RamosFe commented Jun 16, 2023

After rebasing with branch 4.4.5 all checks passed.

Selutario

This comment was marked as resolved.

Sign in to view

@Selutario Selutario merged commit ae9542f into 4.4.5 Jun 20, 2023
49 checks passed
@Selutario Selutario deleted the fix/17510-invalid-azure-range branch June 20, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Selutario Selutario Selutario approved these changes

@GGP1 GGP1 GGP1 approved these changes

Assignees

@RamosFe RamosFe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backport Azure InvalidRange error fix
3 participants
@RamosFe @Selutario @GGP1