Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS Wodle - Deleted repeated classes definitions. #17655

Merged
merged 1 commit into from Jun 28, 2023
Merged

AWS Wodle - Deleted repeated classes definitions. #17655

merged 1 commit into from Jun 28, 2023

Conversation

RamosFe
Copy link
Member

@RamosFe RamosFe commented Jun 26, 2023

Related issue
#17569

Description

Deleted definitions of repeated classes in the AWS wodle.

@RamosFe RamosFe linked an issue Jun 26, 2023 that may be closed by this pull request
Class repetition in the AWS module #17569
Closed
@GGP1 GGP1 self-requested a review June 26, 2023 16:35
GGP1
GGP1 approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@GGP1 GGP1 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note: I'm leaving it on hold because of the failed checks, as soon as they are fixed in the parent branch we can rebase and move it to the final review

@Selutario Selutario merged commit 3db8923 into 4.6.0 Jun 28, 2023
49 checks passed
@Selutario Selutario deleted the fix/17569-aws-class-repetition branch June 28, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Selutario Selutario Selutario approved these changes

@GGP1 GGP1 GGP1 approved these changes

Assignees

@RamosFe RamosFe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Class repetition in the AWS module
3 participants
@RamosFe @Selutario @GGP1