Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework SCA policy for Ubuntu Linux 20.04 (CIS v2.0.0) #17794

Merged
merged 1 commit into from Jul 11, 2023

Conversation

IsExec
Copy link
Member

@IsExec IsExec commented Jul 7, 2023

Component Action type Main Issue
SCA Create #14358

Main tasks

  • Use the latest CIS benchmark PDF Draft version - CIS Amazon Linux 2022 Benchmark v1.0.0 Draft
  • Verify IDs numbers.
  • Verify texts are correct: Title, Description, Rationale and Remediation.
  • Verify Compliance: CIS, CIS_CSC.
  • Verify condition and rules:
    • To Pass.
    • To Fail.

Issue QA:

  • TBD

PR Tests

Syntax and semantic

  • a) ID of each policy must be contiguous.
  • b) The order and format set in Documentation must be respected.
  • c) YML must be valid to avoid errors.

Content

  • a) Compare each check with its analog from CIS Benchmark.
  • b) Try maintaining each rule as similar as possible with the Audit section from the CIS check.
  • c) Check that the commands provide the expected output.
  • d) When a failure is discovered, check similar policies to avoid repetition of the issue.

Unit testing

  • a) Output from ossec.log after the SCA scan and a raw output of the result of the checks.
Tests results

Analysisd (server or local)

analysisd.debug=2

Auth daemon debug (server)

authd.debug=0

Exec daemon debug (server, local, or Unix agent)

execd.debug=0

Monitor daemon debug (server, local, or Unix agent)

monitord.debug=0

Log collector (server, local or Unix agent)

logcollector.debug=0

Integrator daemon debug (server, local, or Unix agent)

integrator.debug=0

Unix agentd

agent.debug=2

Deployment

  • a) If the policy it's new, it must be added to the sca.files templates.
  • b) If the OS has many supported SCA policies, a policy must be set as the default policy. (as example)

Documentation

  • a) Ensure documentation SCA list includes the created or updated SCA.

@IsExec IsExec linked an issue Jul 7, 2023 that may be closed by this pull request
5 tasks
@IsExec IsExec changed the base branch from master to 4.5.1 July 7, 2023 19:10
@72nomada 72nomada self-requested a review July 10, 2023 15:00
@72nomada 72nomada assigned 72nomada and IsExec and unassigned 72nomada Jul 10, 2023
@72nomada 72nomada marked this pull request as ready for review July 10, 2023 15:01
@72nomada 72nomada marked this pull request as draft July 11, 2023 05:25
@72nomada 72nomada changed the title Rework sca policy for ubuntu linux 2004 (v2.0.0) Rework SCA policy for Ubuntu Linux 20.04 (CIS v2.0.0) Jul 11, 2023
@72nomada 72nomada marked this pull request as ready for review July 11, 2023 09:20
Copy link
Contributor

@72nomada 72nomada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@72nomada 72nomada merged commit 10a0330 into 4.5.1 Jul 11, 2023
49 checks passed
@72nomada 72nomada deleted the Rework-sca-policy-for-ubuntu-linux-2004-1 branch July 11, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants