Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CredSSP encryption enforcement at Windows Benchmarks for SCA #17941

Merged
merged 1 commit into from Jul 19, 2023

Conversation

vikman90
Copy link
Member

@vikman90 vikman90 commented Jul 18, 2023

Related issue
Closes #17897

This PR aims to fix a typo in multiple Windows Benchmarks check for "Encryption Oracle Remediation".

The title states:

The recommended state for this setting is: Enabled: Force Updated Clients.

According to the documentation (Encryption Oracle Remediation), the value 0 corresponds to "Force Updated Clients".

On the other hand, cis_win2019.yml already has the correct value.

Thanks to @oleKHard for reporting this problem.

@vikman90 vikman90 added type/bug Something isn't working feed/sca Security Configuration Assessment policies related issues labels Jul 18, 2023
@vikman90 vikman90 self-assigned this Jul 18, 2023
@vikman90 vikman90 requested a review from a team July 18, 2023 07:10
Copy link
Member

@jk-olaoluwa jk-olaoluwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jk-olaoluwa jk-olaoluwa added level/task type/enhancement New feature or request labels Jul 18, 2023
@vikman90 vikman90 merged commit 761a36b into 4.5.1 Jul 19, 2023
49 checks passed
@vikman90 vikman90 deleted the 17897-fix-sca-check-27192 branch July 19, 2023 06:43
@vikman90 vikman90 removed the type/enhancement New feature or request label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feed/sca Security Configuration Assessment policies related issues level/task type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants