Fix SCA checks query with condition field #18434
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Overwrites the
_pass_filter
method onWazuhDBQuerySCACheckIDs
to avoid skipping filters that have the fieldcondition
and the valueall
.To do this, I added the
field
value to_pass_filter
because overwriting the method to just returnFalse
would cause an undesired behavior when receiving queries to any other field with the valueall
.For example,
policy_id=all
would return results with apolicy_id
equal toall
instead of all of them (expected behaviour, as in all the other endpoints).Logs/Alerts example
/sca/001/checks/cis_ubuntu20-04?q=condition=all
Tests
test_sca_endpoints.tavern.yaml