Improving reliability of the signature verification mechanism #19811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initializing structures. Avoid network requests while checking certificate revocation. Using explicit invalid handle instead of null for WinVerifyTrust().
pereyra-m
force-pushed
the
bug/18591-rpcrt4.dll-crash
branch
from
8d5bc33
to
2d79d17
Compare
Dwordcito
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was reported that for some specific environments, the signature verification mechanism performs some RPC calls that end up in a system crash.
To avoid this situation, the following improvements are proposed:
INVALID_HANDLE_VALUEwas used instead ofNULLto indicate that we don't want UI interactions (see https://learn.microsoft.com/en-us/windows/win32/api/wintrust/nf-wintrust-winverifytrust#parameters)WTD_CACHE_ONLY_URL_RETRIEVALwas added to avoid network calls while checking the certificate revocation. Only the cache will be used (see https://learn.microsoft.com/en-us/windows/win32/api/wintrust/ns-wintrust-wintrust_data#members)Tests
A user has confirmed that these changes make the agent stop crashing (#18591 (comment))