Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework SCA Policy Windows 11 Enterprise #20044

Merged

Conversation

ooniagbi
Copy link
Member

@ooniagbi ooniagbi commented Nov 3, 2023

Component Action type Main Issue
SCA Create #18306

Main tasks

  • Use the latest CIS benchmark PDF from https://downloads.cisecurity.org/#/
  • Verify IDs numbers.
  • Verify texts are correct: Title, Description, Rationale and Remediation.
  • Verify Compliance: CIS, CIS_CSC.
  • Verify condtion and rules:
    • To Pass.
    • To Fail.
  • Solve Related issues:

Checks

Syntax and semantic

  • a) ID of each policy must be contiguous.
  • b) The order and format set in Documentation must be respected.
  • c) YML must be valid to avoid errors.

Content

  • a) Compare each check with its analog from CIS Benchmark.
  • b) Try maintaining each rule as similar as possible with the Audit section from the CIS check.
  • c) Check that the commands provide the expected output.
  • d) When a failure is discovered, check similar policies to avoid repetition of the issue.

Unit testing

  • a) Output from agent.log after the SCA scan and a raw output of the result of the checks.
Tests results

Analysisd (server or local)

analysisd.debug=2

Auth daemon debug (server)

authd.debug=0

Exec daemon debug (server, local, or Unix agent)

execd.debug=0

Monitor daemon debug (server, local, or Unix agent)

monitord.debug=0

Log collector (server, local or Unix agent)

logcollector.debug=0

Integrator daemon debug (server, local or Unix agent)

integrator.debug=0

Unix agentd

agent.debug=2

2023/11/03 17:33:18 sca: INFO: Evaluation finished for policy 'C:\Program Files (x86)\ossec-agent\ruleset\sca\cis_win11_enterprise.yml'
2023/11/03 17:33:18 sca: INFO: Security Configuration Assessment scan finished. Duration: 7 seconds.

Deployment

  • a) If the policy it's new, it must be added to the sca.files templates.
  • b) If the OS has many supported SCA policies, a policy must be set as the default policy. (as example)

Documentation

  • a) Ensure documentation SCA list includes the created or updated SCA.

@ooniagbi ooniagbi linked an issue Nov 3, 2023 that may be closed by this pull request
21 tasks
@ooniagbi ooniagbi requested a review from IsExec November 3, 2023 16:03
Copy link
Member

@IsExec IsExec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ooniagbi ooniagbi merged commit 19c767a into 4.8.0 Nov 3, 2023
8 of 23 checks passed
@ooniagbi ooniagbi deleted the 17330-rework-sca-policy-for-microsoft-windows-11-enterprise branch November 3, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework SCA Policy for Microsoft Windows 11 Enterprise
2 participants