Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for input data sanitization at Eventchannel decoder #20735

Merged
merged 6 commits into from Dec 12, 2023
Merged

Check for input data sanitization at Eventchannel decoder #20735

merged 6 commits into from Dec 12, 2023

Conversation

vikman90
Copy link
Member

Related issue
#20734

This PR aims to fix the input data sanitization in the Eventchannel decoder at wazuh-analysisd:

  • Normalize loops (assure that variable l is resetted).
  • Check that <Provider> contains some attributes.
  • Check that <TimeCreated> contains some attributes.
  • Check that <Execution> contains some attributes.

Tests

  • Unit tests have been added for the cases above.

@vikman90 vikman90 self-assigned this Dec 12, 2023
@vikman90 vikman90 added the type/bug Something isn't working label Dec 12, 2023
juliancnn
juliancnn previously approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@juliancnn juliancnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

juliancnn
juliancnn approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@juliancnn juliancnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

JcabreraC
JcabreraC approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@JcabreraC JcabreraC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@vikman90 vikman90 merged commit 00d2069 into 4.7.2 Dec 12, 2023
18 checks passed
@vikman90 vikman90 deleted the fix/563-eventchannel-decoder branch December 12, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliancnn juliancnn juliancnn approved these changes

@JcabreraC JcabreraC JcabreraC approved these changes

Assignees

@vikman90 vikman90

Labels
type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vikman90 @juliancnn @JcabreraC