Print message in hex format when remoted doesn't recognize it #21011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdvendramini
previously approved these changes
Dec 21, 2023
TomasTurina
force-pushed
the
17596_print_unexpected_msg_remoted
branch
from
200f875
to
f042742
Compare
vikman90
requested changes
Dec 21, 2023
There was a problem hiding this comment.
@TomasTurina the fix looks good but I would like to move the code to another function, like
void print_hex_string(char * buffer, size_t buffer_size, const char * data, size_t data_len);This way we let the code be more understandable, and we can add Doxygen and unit tests.
Thanks.
vikman90
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of #17596, this PR adds information to the
wazuh-remoteddaemon log that will help in the future identify when an agent sends an unexpected message, so we can identify the cause of this. Additionally, an error message becomes a warning to avoid failures in Jenkins checks when this happens, as this is a situation where the manager and agent can recover without intervention.Logs/Alerts example
Tests