-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create agent database files from template atomically #23216
Conversation
Failing checksscan-build-macos-agent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It LGTM but in my opionion we could add those little details
2567a2a
to
14e9785
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This pull request aims to address a fault tolerance issue in wazuh-db, which may result in empty database files if abruptly closed. This scenario can occur in an environment where the service takes longer than a minute to shut down, as it forcibly terminates wazuh-db with SIGKILL.
Proposed solution
The proposed solution entails:
Not considered
Tests
wdb_create_agent_db2
.Manual test
Before
After