Fix agent connection in TCP mode on Windows XP #2329
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained at the issue comment, the network API for Windows does not support the flag
MSG_WAITALL
inrecv()
. This prevents the agent from connecting to the manager in TCP mode on Windows XP.Solution
We implemented the
os_recv_waitall()
function to emulate the WAITALL behavior. We changedOS_RecvSecureTCP()
to use that function and replaced calls torecv()
in:Tests
Platforms