Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections on conf and replacing timeout like agentd enrollment test #23608

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

LucioDonda
Copy link
Member

@LucioDonda LucioDonda commented May 23, 2024

Related issue
#23698

Description

Tests and corrections for itegration test on windows enrolment.
Conf has 2 duplicated lines and we're replicating what's being done on the other integration enrollment test for windows.

Configuration options

Logs/Alerts example

@cborla cborla linked an issue May 24, 2024 that may be closed by this pull request
@cborla cborla self-requested a review May 24, 2024 00:27
cborla
cborla previously approved these changes May 24, 2024
Copy link
Member

@cborla cborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LucioDonda LucioDonda force-pushed the test/23201-windows-agent-auth-enrollment branch from e3ae697 to d24ef80 Compare June 6, 2024 15:00
@LucioDonda LucioDonda requested a review from cborla June 11, 2024 22:54
@LucioDonda LucioDonda force-pushed the test/23201-windows-agent-auth-enrollment branch from aabac47 to 2e17bec Compare June 11, 2024 23:06
cborla
cborla previously approved these changes Jun 12, 2024
Copy link
Member

@cborla cborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LucioDonda LucioDonda force-pushed the test/23201-windows-agent-auth-enrollment branch 2 times, most recently from dfedd42 to 8a5c3e4 Compare June 12, 2024 18:25
@cborla
Copy link
Member

cborla commented Jun 13, 2024

Failing test

Copy link
Member

@cborla cborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vikman90 vikman90 merged commit a90065a into 4.9.0 Jun 13, 2024
29 of 31 checks passed
@vikman90 vikman90 deleted the test/23201-windows-agent-auth-enrollment branch June 13, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix failed Integration tests for enrollment on Windows
3 participants